Add pdf handling in render_respond_to_format_with_error_message#3482
Merged
aaronskiba merged 3 commits intodevelopmentfrom Mar 24, 2025
Merged
Add pdf handling in render_respond_to_format_with_error_message#3482aaronskiba merged 3 commits intodevelopmentfrom
render_respond_to_format_with_error_message#3482aaronskiba merged 3 commits intodevelopmentfrom
Conversation
`render_respond_to_format_with_error_message` is called both when rescuing from Pundit::NotAuthorizedError and ActiveRecord::RecordNotFound. The method works properly with .html format, but prior to this change, ActionController::UnknownFormat was thrown for .pdf format.
johnpinto1
approved these changes
Mar 17, 2025
Contributor
johnpinto1
left a comment
johnpinto1
left a comment
There was a problem hiding this comment.
I have tested pdf export using a existing plan and a non existing plan:
- Existing plan (authorised) works as before:
- Non existing plan (id=1234)
http://localhost:3000/plans/1234/export?format=pdf&export%5Bform%5D=true&phase_id=&export%5Bproject_details%5D=true&export%5Bquestion_headings%5D=true&export%5Bunanswered_questions%5D=true&export%5Bformatting%5D%5Bfont_face%5D=Roboto%2C+Arial%2C+Sans-Serif&export%5Bformatting%5D%5Bfont_size%5D=10&export%5Bformatting%5D%5Bmargin%5D%5Btop%5D=25&export%5Bformatting%5D%5Bmargin%5D%5Bbottom%5D=20&export%5Bformatting%5D%5Bmargin%5D%5Bleft%5D=12&export%5Bformatting%5D%5Bmargin%5D%5Bright%5D=12&button=
Responds with error message
- Plan (id=1) which exists, but user is not authorised to download now responds with message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3414
Changes proposed in this PR:
render_respond_to_format_with_error_messageis called both when rescuing from Pundit::NotAuthorizedError and ActiveRecord::RecordNotFound. The method works properly with .html format, but prior to this change, ActionController::UnknownFormat was thrown for .pdf format.