Skip to content

[CU-86b76fmp8] Add Repository interface and unit tests for Check/Get#12

Merged
mbarkley merged 4 commits into
mainfrom
add-unit-tests-CU-86b76fmp8
Mar 23, 2026
Merged

[CU-86b76fmp8] Add Repository interface and unit tests for Check/Get#12
mbarkley merged 4 commits into
mainfrom
add-unit-tests-CU-86b76fmp8

Conversation

@mbarkley
Copy link
Copy Markdown

@mbarkley mbarkley commented Mar 20, 2026

Make Check/Get testable by injecting a Repository interface instead of creating the OCI client internally. Add unit tests to establish a baseline before extending the implementation. Removed github automation from upstream that checked PR title and added license headers

@mbarkley mbarkley force-pushed the add-unit-tests-CU-86b76fmp8 branch from 274d849 to 1e921b2 Compare March 20, 2026 22:34
@mbarkley mbarkley force-pushed the add-unit-tests-CU-86b76fmp8 branch from 9e0de03 to d00608e Compare March 23, 2026 14:32
@mbarkley mbarkley force-pushed the add-unit-tests-CU-86b76fmp8 branch 3 times, most recently from 45e9a55 to fa04828 Compare March 23, 2026 14:55
@mbarkley mbarkley marked this pull request as draft March 23, 2026 15:05
@mbarkley mbarkley marked this pull request as draft March 23, 2026 15:05
@mbarkley mbarkley marked this pull request as ready for review March 23, 2026 15:33
Copy link
Copy Markdown

@jfuerth jfuerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea injecting the repo. Just a few suggestions to consider.

Comment thread pkg/resource/check_test.go Outdated
Comment thread pkg/resource/version_test.go
@mbarkley mbarkley force-pushed the add-unit-tests-CU-86b76fmp8 branch from fa04828 to 3d8d00a Compare March 23, 2026 16:49
@mbarkley mbarkley merged commit f5e89a0 into main Mar 23, 2026
3 checks passed
@mbarkley mbarkley deleted the add-unit-tests-CU-86b76fmp8 branch March 23, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants