feat: update tmforum-api in dev environment#1515
Draft
versatildefuy wants to merge 1 commit intoDOME-Marketplace:mainfrom
Draft
feat: update tmforum-api in dev environment#1515versatildefuy wants to merge 1 commit intoDOME-Marketplace:mainfrom
versatildefuy wants to merge 1 commit intoDOME-Marketplace:mainfrom
Conversation
wistefan
requested changes
Aug 5, 2025
| # -- should tm-forum-api be enabled | ||
| enabled: true | ||
|
|
||
| defaultConfig: |
Collaborator
There was a problem hiding this comment.
Why are you adding things here, that are already in the access-node? With your PR https://github.com/DOME-Marketplace/access-node/pull/81/files this version is already set and the additional env vars are also already in place. Duplicating that will bring inconsistencies in the future. Beside that, why dont you update the access-node chart in this PR?
Author
There was a problem hiding this comment.
Hello @wistefan, this PR is a draft until we can update the access-node version. This PR was created before the team asked us to upgrade access-node chart version. Once DOME-Marketplace/access-node#81 is closed I will update the content of this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tmforum-api in dev environment to version 1.3.6.
Adds similar sbx similar pods and tls secret generation.
Also changes bae configuration pointing to new tmforum pods uris.