Emacs 31 upgrade - #19
Merged
Merged
Conversation
The guard matched the bare string "rm" anywhere in the command, so any word ending in rm -- terraform, confirm, perform, form -- tripped it. The -r/-f scan also ran across the entire command rather than one invocation, blocking "rm a.txt && grep -r -f pat", and the xargs rule blocked anything containing rm after xargs, such as "xargs grep -l form". Replace the regex stack with a per-segment tokenizer: split on shell separators, skip wrapper words (sudo, env, xargs, bash -c) and VAR= prefixes, resolve the command word, then attribute flags only to that rm. Stops at -- so "rm -- -rf" is treated as a filename. Net effect is stricter, not looser: it still catches every previous true positive plus bash -c "rm -rf /", which the old pattern missed entirely. Covered by a 36-case regression table.
31.0.91 is a pretest off the emacs-31 branch. It carries the upstream fix for HTTP 402 (bug#81101), which previously raised an error from inside the url-http process filter and left eww stuck on "Loading..." for sites using 402 as an anti-bot challenge, so no local patch is needed. The tap's emacs-plus@32 is master, not a newer stable. Point BREW_FORMULA, the Brewfile, and the docs at @31, and derive the dashboard title from emacs-major-version instead of a literal that had already drifted a version behind. Document the two traps this upgrade hit: emacs-plus's bin/emacs is a wrapper that prefers /Applications/Emacs.app, so bumping the formula alone keeps launching the old version under a new keg name, and a major-version bump invalidates every .elc, which needs package-recompile-all rather than byte-recompile-directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.