Conversation
…iber via IPipelineHandlerTypeAccessor InstrumentedHandler stamped the per-handler span name and mediator.handler.type from inner.GetType(). When a transparent handler decorator wraps the subscriber (e.g. a timing/profiling wrapper), that returned the decorator's type — not the concrete handler — so the span carried a wrapper's (often compiler-mangled) name and, because such a wrapper's generic is parameterized by the notification, every subscriber collapsed to one type. Resolve the concrete handler through IPipelineHandlerTypeAccessor — the same seam the request (MediatorDispatchTracingObserver) and stream (MediatorStreamTracingBehavior) paths already use — for both the span name and the handler.type tag. Bump DSoftStudio.Mediator.OpenTelemetry to 1.1.0-rc.4.
Contributor
SummarySummary
CoverageDSoftStudio.Mediator - 98.4%
DSoftStudio.Mediator.Abstractions - 91.3%
DSoftStudio.Mediator.FluentValidation - 100%
DSoftStudio.Mediator.Generators - 91.9%
DSoftStudio.Mediator.HybridCache - 100%
DSoftStudio.Mediator.OpenTelemetry - 96.8%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstrumentedHandler stamped the per-handler span name and mediator.handler.type from inner.GetType(). When a transparent handler decorator wraps the subscriber (e.g. a timing/profiling wrapper), that returned the decorator's type — not the concrete handler — so the span carried a wrapper's (often compiler-mangled) name and, because such a wrapper's generic is parameterized by the notification, every subscriber collapsed to one type.
Resolve the concrete handler through IPipelineHandlerTypeAccessor — the same seam the request (MediatorDispatchTracingObserver) and stream (MediatorStreamTracingBehavior) paths already use — for both the span name and the handler.type tag.
Bump DSoftStudio.Mediator.OpenTelemetry to 1.1.0-rc.4.