Conversation
…reenshots, add OTel-bridge captures + FILE-path known issue Verified doc claims against the implementation (multi-agent review) and fixed the ones that would mislead a user: - OpenTelemetry bridge live capture marked **Available** (was "in development"); Mode B rewritten to present tense. - profiler-not-attaching: DSoftMediatorProfilingEnabled default is **off** (was "true"); added the config-scoped + AOT/CI/publish force-off cause; removed the non-existent Settings-panel profiling toggle and the fictional "Snapshot" mechanism. - analyzer-errors: machine-local injection model (no longer the solution Directory.Build.props); correct disable property (DSoftMediatorProfilingEnabled); DiagnosticsEnabled caveat. - activation-failed: removed the dead /transfer URL and non-existent "Move to another machine"; use per-machine Deactivate. - installation/index: correct VS Code extension id (DSoftStudio.mediator-pipeline-explorer) and per-platform vsix asset name. - quick-start: Behaviors -> Components rename; correct pipeline-mode badge labels; Detach/Dock and section-filter scoped to Visual Studio. - server-startup: added the .NET 8 runtime and wrong-platform-vsix causes. - output-channel names (Mediator Server / DSoftStudio Mediator); OSS integration nits (HybridCache overhead wording, OTel observer-vs-behavior). Refreshed 11 screenshots to the current UI (Components rename, populated FILE, VS empty state, detached graph) and added two OpenTelemetry-bridge captures (enriched db-dependency flame + live fan-out). Documented the layered-solution FILE-path / Open-in-Editor limitation as a known issue with the rebuild workaround.
Contributor
SummarySummary
CoverageDSoftStudio.Mediator - 98.2%
DSoftStudio.Mediator.Abstractions - 91.3%
DSoftStudio.Mediator.FluentValidation - 100%
DSoftStudio.Mediator.Generators - 91.8%
DSoftStudio.Mediator.HybridCache - 100%
DSoftStudio.Mediator.OpenTelemetry - 96.8%
|
… complexity + ThrowIfNull) Address the production-code (src/) findings from the SonarCloud scan; the remaining open issues are test-only and largely intentional. - PipelineChainHandler: replace the single-iteration `foreach+break` used to pick the first dispatch observer (S1751 reliability bug) with the same array-materialize-then-[0] pattern the constructor already uses for the behavior/processor collections — no LINQ, no boxed enumerator, behavior preserved (first observer wins, null when none). - HandlerLifetimeOptimizer: use ArgumentNullException.ThrowIfNull in Stage and Apply (consistent with the rest of the library), and extract the "last winning descriptor" scan into FindWinningDescriptorIndex to bring Apply's cognitive complexity under the threshold. - DependencyInjectionGenerator.GetHandlerInfo: split into GetDependencyTypes, GetExplicitLifetime and MatchHandlerInterface (with a TypeArg helper); the three near-identical handler-interface branches collapse into one switch. Behavior preserved — same HandlerInfo output. Build: core + generators 0 errors. Tests: 556/556 green (Tests 412, OpenTelemetry 102, FluentValidation 21, HybridCache 13, InternalsVisibleTo 4, ModularMonolith 4).
… bypass sonar.exclusions) sonar.exclusions already lists tests/**, but that only filters SonarCloud's own (csharpsquid) analysis — externally-imported Roslyn issues (CA*, DSOFT*) are attached to files during the MSBuild build and are NOT subject to sonar.exclusions, so advisory findings on test fixtures (CA1861, DSOFT006, CA2263) kept surfacing on the dashboard. Add a multicriteria rule (e4) with ruleKey="*" and resourceKey="tests/**/*" — the documented mechanism that ignores every issue, imported ones included, on a path. Test fixtures deliberately exercise raw IRequest<T> dispatch and mirror the generator's runtime-Type registrations; those advisories don't apply to throwaway test types.
Mediator + Abstractions 1.3.0-rc.2 -> 1.3.0, OpenTelemetry 1.1.0-rc.4 -> 1.1.0, HybridCache + FluentValidation 1.0.9-rc.2 -> 1.0.9. Changelogs stamped 2026-07-08 with stable companion versions; rc bookkeeping comment removed from the OpenTelemetry csproj.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified doc claims against the implementation (multi-agent review) and fixed the ones that would mislead a user:
Refreshed 11 screenshots to the current UI (Components rename, populated FILE, VS empty state, detached graph) and added two OpenTelemetry-bridge captures (enriched db-dependency flame + live fan-out). Documented the layered-solution FILE-path / Open-in-Editor limitation as a known issue with the rebuild workaround.