Enable preboot event replay for shorter apparent TTI#1761
Draft
ybnd wants to merge 11 commits intoDSpace:mainfrom
Draft
Enable preboot event replay for shorter apparent TTI#1761ybnd wants to merge 11 commits intoDSpace:mainfrom
ybnd wants to merge 11 commits intoDSpace:mainfrom
Conversation
preboot is triggered when the app first becomes stable, which caused the app to hang once CSR started Tracked the issue down to initialization - GoogleAnalyticsService.addTrackingIdToPage() - AuthService.trackTokenExpiration()
SSR HTML inlines CSS into style.ng-transition elements. By default, Angular removes these as soon as CSR starts. Because preboot buffers CSR off-screen, the SSR HTML remains visible during the transition - without CSS. This workaround strips the ng-transition attribute from SSR styles so they aren't removed automatically and subsequently removes these same styles once preboot is finished.
On the server, @slideSidebarPadding always resolved to 'expanded' because slideSidebarOver did not emit true
…imize-initial-page-load-by-leveraging-preboot
This reverts commit d1741e2.
6 tasks
|
This pull request introduces 1 alert when merging 818c142 into f6d2014 - view on LGTM.com new alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
This (work-very-much-in-progress) PR continues the integration of Angular
prebootinto DSpace by enabling event replay, which further improves perceived loading performance by allowing (limited) interaction with the page during the SSR→CSR transition, e.g.:While working on #1760 it became clear that this feature won't be easy (or quick) to integrate
idto support event replay. Currently this is not the case for a serious number of our components. For now, this branch can serve as a showcase of the kind & number of changes we would need to make to address this.a.btn-style buttons won't work with event replay if defined with[routerLink]=""; they should usehref="javascript:void(0)";instead.Instructions for Reviewers
TBD
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.