improvement(docs): lib-bootstrap pattern + development branch model + jsDelivr URLs#68
Conversation
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, push a new commit or reopen this pull request to trigger a review.
8c4d9ba to
e03d52b
Compare
|
Closing in favor of the OEM redo design captured at #74. The original approach (runtime lib bootstrap via jsDelivr, "baseline" naming with static policy files, hash placeholders) is being replaced with CI-generated fat scripts, internet check only at the install step, and RMM-env-var-driven Branch retained ... cherry-pick anything worth preserving from the new PR's branch. |
Summary
Three load-bearing doc changes plus the repo-shape flip that the docs describe:
oem-shared/lib/*,s3-api-lib/*) fetch them at runtime from jsDelivr pinned to a release tag and verify SHA256 before dot-sourcing. New commented-out block at the top ofscript-template-powershell.ps1, full recipe inCLAUDE.mdunder Common Patterns. Future-state note that CI may concatenate libs into fat scripts and turn the bootstrap into a no-op (Phase 2); until then, runtime fetch is the pattern.developmentis now the default branch ... allbug/,refactor/,improvement/,feature/PRs target it (squash merge).mainis production ... onlydevelopment -> mainpromotions and hotfixes land here, always via merge commit. Hotfixes offmainget back-merged intodevelopmentso the next promotion doesn't undo them. Matches the Change Taxonomy merge-method canon. CLAUDE.md Git Workflow section rewritten end-to-end.https://cdn.jsdelivr.net/gh/dtc-inc/msp-script-library@<tag>/<path>.@releaseis the moving production tag (advanced on each promotion),@vX.Y.Zis the immutable pin. README gains a "Script Delivery (jsDelivr)" section explaining the tag conventions.Repo operations also landed alongside this PR
The doc changes describe a model that already needed the repo to be reshaped. Done out-of-band before this PR opened so the PR body is accurate:
developmentbranch fromorigin/main(identical content, no drift at creation).maintodevelopment. New PRs targetdevelopmentby default.maintodevelopment(PRs Dell7450 NVME Firmware Update #31, Enhancement/vixtemp cleanup #35, Add VixTemp folder cleanup script for dental imaging workstations #40, Add Storage Growth Monitor script for Ninja RMM (Ticket 1123004) #41, Add Schick 33/Elite USB sensor deployment automation script #42, Add weekly orphaned installer patch monitor for NinjaRMM #43, Add on-demand orphaned installer patch cleanup with safety quarantine #44, Add server lifecycle audit PowerShell script #47, Add Hyper-V host lifecycle audit script #48, Add NinjaRMM GUID to Halo PSA GUID Sync Script #49, Add Google Drive silent install + DC exclusion on SID detection #60, Add 180-day deletion for inactive administrator accounts #63, BitLocker enable + inventory rewrite with recovery key automation #64, Add SID change script + Dell server tools installer #66, improvement(docs): sync CLAUDE.md with DTC canonical change-taxonomy #67).release(signed annotated) on the tip ofmainso jsDelivr's@releaseresolves today. The tag is moving ... it will advance on eachdevelopment -> mainpromotion.main). Mirrorsdtc-inc/client-portal'sreleaseruleset shape.developmentis already covered by the org-level "Default Branch Protection" ruleset via~DEFAULT_BRANCH(PR required, 1 review). Status checks slot is ready for when CI lands.Test plan
@releaseonce a real lib lands behind itdevelopment, dry-run thedevelopment -> mainpromotion flow (merge commit, then advancereleasetag)