Skip to content

Johnfreeman/issue341 dont ignore python#342

Merged
jcfreeman2 merged 2 commits intodevelopfrom
johnfreeman/issue341_dont_ignore_python
Feb 26, 2026
Merged

Johnfreeman/issue341 dont ignore python#342
jcfreeman2 merged 2 commits intodevelopfrom
johnfreeman/issue341_dont_ignore_python

Conversation

@jcfreeman2
Copy link
Collaborator

Description

Addresses Issue #341, see for a description of the problem this PR solves for.

To test, you can of course recreate the problem described using our most recent version of daq-buildtools and last night's nightly, and then see what happens when this feature branch is used. Also note I added a test to test_daq-buildtools.sh which explicitly tests for what this PR solves.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Checklist below is N/A for daq-buildtools; see what I wrote above for into on how to test.

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

John Freeman added 2 commits February 26, 2026 10:53
…kages; also, improve Python installation benchmark messaging
Copy link
Contributor

@andrewmogan andrewmogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed the issue when building a local area using the latest tag of daq-buildtools, and confirmed that the issue is resolved when using this branch. I checked out only drunc in to pythoncode and saw that it successfully pip installed. I also see that all checks pass in test_daq-buildtools.sh, including the newly added ones.

Approved.

@jcfreeman2 jcfreeman2 merged commit f7332b9 into develop Feb 26, 2026
2 checks passed
@jcfreeman2 jcfreeman2 deleted the johnfreeman/issue341_dont_ignore_python branch February 26, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: dbt-build is a no-op if only Python repos are in the work area

2 participants