Skip to content

JCF: Issue #343: allow users to skip installation of packages in ./py…#344

Merged
jcfreeman2 merged 1 commit intodevelopfrom
johnfreeman/issue343_skip_python_install
Feb 26, 2026
Merged

JCF: Issue #343: allow users to skip installation of packages in ./py…#344
jcfreeman2 merged 1 commit intodevelopfrom
johnfreeman/issue343_skip_python_install

Conversation

@jcfreeman2
Copy link
Collaborator

…thoncode

Description

See issue #343 for details

To test, basically just see what supplying --skip-python-install or -sp at the command line to dbt-build will do.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist N/A for daq-buildtools; see what I wrote above for testing suggestions.

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

Copy link
Contributor

@andrewmogan andrewmogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised, and the usual test_daq-buildtools.sh checks all pass.

Approved.

@jcfreeman2 jcfreeman2 merged commit 85b5d5b into develop Feb 26, 2026
2 checks passed
@jcfreeman2 jcfreeman2 deleted the johnfreeman/issue343_skip_python_install branch February 26, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants