Skip to content

Updating the set connectivity script to work with ccm config changes#603

Closed
MRiganSUSX wants to merge 6 commits intodevelopfrom
mrigan/k8s_changes
Closed

Updating the set connectivity script to work with ccm config changes#603
MRiganSUSX wants to merge 6 commits intodevelopfrom
mrigan/k8s_changes

Conversation

@MRiganSUSX
Copy link
Contributor

Updating the set_connectivity_service_port functions to work with the dynamic port changes in oks.
Related PR: DUNE-DAQ/daqsystemtest#244

@MRiganSUSX MRiganSUSX requested review from bieryAtFnal and removed request for bieryAtFnal October 9, 2025 16:13
@MRiganSUSX MRiganSUSX marked this pull request as draft October 9, 2025 16:30
@bieryAtFnal
Copy link
Contributor

I find that the lines that were commented out with

 # This block has been removed as it was redundant and caused the confusing printout.

are needed to get the example_system_test to run successfully...

@MRiganSUSX
Copy link
Contributor Author

Now updated to work with example_system_test.py.

@MRiganSUSX MRiganSUSX marked this pull request as ready for review October 15, 2025 12:48
@bieryAtFnal
Copy link
Contributor

I verified that a local-1x1-config system run with drunc interactively now works fine (with a modified connectivity service port). And, the example_system_test works fine.

My sense is that it would be better to enhance the existing find_free_port utility to support a required range of ports, though, instead of adding a new function just for K8s. I can work on that, if it would be helpful...

@MRiganSUSX
Copy link
Contributor Author

@bieryAtFnal Please, go ahead. I can also rework it if you are very time limited, but would need more detailed description of the preferred outcome.

Kurt Biery added 2 commits October 23, 2025 12:16
… a single one that supports an optional range; promoted a few warnings to errors in set_connectivity_service_port.py
@bieryAtFnal
Copy link
Contributor

I have re-merged the develop branches in this repo and the daqsystemtest repo to the mrigan/k8s_changes branches so that they can be tested with the latest nightly build...

In addition, I've created a branch named kbiery/tweaks_to_k8s_changes in this repo on which I've made some changes that I'd like to propose that we make to the original changes in this PR. My changes combine the find_free_k8s_nodeport and find_free_port functions into a single one that supports an optional range, and they promoted a few warnings to errors in set_connectivity_service_port.py. I've verified that our usual regression tests work with those proposed changes. @MRiganSUSX , when you get a chance, please let me know what you think.

@MRiganSUSX
Copy link
Contributor Author

Superseded by #608.

@MRiganSUSX MRiganSUSX closed this Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants