Skip to content

Use new generate_modules signature#620

Merged
gcrone merged 1 commit intodevelopfrom
gcrone/private-session
Mar 11, 2026
Merged

Use new generate_modules signature#620
gcrone merged 1 commit intodevelopfrom
gcrone/private-session

Conversation

@gcrone
Copy link
Contributor

@gcrone gcrone commented Mar 2, 2026

Description

Update GraphBuilder app to pass configuration helper to generate_modules

Requires appmodel PR DUNE-DAQ/appmodel#171

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@mroda88 mroda88 added enhancement New feature or request deliverable subtask A change that delivers part or all of the functionality for a daq-deliverable Issue labels Mar 11, 2026
Copy link
Contributor

@mroda88 mroda88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcrone gcrone merged commit 4a5c17f into develop Mar 11, 2026
4 checks passed
@gcrone gcrone deleted the gcrone/private-session branch March 11, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deliverable subtask A change that delivers part or all of the functionality for a daq-deliverable Issue enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants