Skip to content

NanoRC to DuneRC name change#482

Merged
bieryAtFnal merged 2 commits intodevelopfrom
kbiery/nanorc_to_dunerc_name_change
Mar 13, 2026
Merged

NanoRC to DuneRC name change#482
bieryAtFnal merged 2 commits intodevelopfrom
kbiery/nanorc_to_dunerc_name_change

Conversation

@bieryAtFnal
Copy link
Collaborator

Description

These changes follow along with the ones in DUNE-DAQ/integrationtest#147. They convert the obsolete "nanorc" name in our integration tests to a more generic "dunerc" name.

Other than observing the new "dunerc" name in the integtest output, users should not notice a difference, and all integtests in this repo should continue to work

Here are suggestions for testing the changes:

DATE_PREFIX=`date '+%d%b'`
TIME_SUFFIX=`date '+%H%M'`

source /cvmfs/dunedaq.opensciencegrid.org/setup_dunedaq.sh
setup_dbt latest
dbt-create -n NFD_DEV_260311_A9 ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}
cd ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}/sourcecode

git clone https://github.com/DUNE-DAQ/daqsystemtest.git -b develop
git clone https://github.com/DUNE-DAQ/dfmodules.git -b kbiery/nanorc_to_dunerc_name_change
cd ..

dbt-workarea-env
dbt-build -j 12
dbt-workarea-env

dunedaq_integtest_bundle.sh -r dfmodules --concise

echo ""
echo -e "\U1F535 \U2705 Note that all of the modified integtests passed, modulo any problems with inserting TAs into latency buffers, which are unrelated. \U2705 \U1F535"
echo ""
echo ""

Type of change

  • Optimization (non-breaking change that improves code/performance)

Testing checklist

  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)

@bieryAtFnal bieryAtFnal requested a review from eflumerf March 11, 2026 18:18
Copy link
Member

@eflumerf eflumerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial comment...Should it be run_dune or run_dunedaq, and check_rc_success(run_dune)?

@bieryAtFnal
Copy link
Collaborator Author

Trivial comment...Should it be run_dune or run_dunedaq, and check_rc_success(run_dune)?

Something to be considered...

@bieryAtFnal bieryAtFnal merged commit bc91f93 into develop Mar 13, 2026
4 checks passed
@bieryAtFnal bieryAtFnal deleted the kbiery/nanorc_to_dunerc_name_change branch March 13, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants