[k8s]: Correct role assignment and termination #770
Open
[k8s]: Correct role assignment and termination #770
Conversation
This was referenced Mar 12, 2026
Collaborator
|
Initial tests demonstrate that this PR does not achieve the desired functionality. I have run the And with And in the I am unsure if this is from the fake app or from this PR, but these apps are still getting marked as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Address issue #768 .
Correctly assign role labels to the pod.
Performs an ordered shutdown of matched processes by their role labels: unknown → application → segment-controller → root-controller → infrastructure-applications. Segment-controllers are further split by tree-id depth, shutting down the deepest first
Type of change
Key checklist
python -m pytest)pre-commit run --all-files)Further checks
(Indicate issue here: # (issue))