Skip to content

Support raw data filenames without timestamps in data_file_checks #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bieryAtFnal merged 3 commits into from
Feb 23, 2026
Merged

Support raw data filenames without timestamps in data_file_checks #146

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88310c5
Modified the data-file-check for the creation_timestamp HDF5 file Att…
bieryAtFnal Feb 5, 2026
8d0d6a7
Merge remote-tracking branch 'origin/develop' into kbiery/support_fil…
Feb 19, 2026
9cd497b
slight change to comment in data_file_checks::check_file_attributes
Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/integrationtest/data_file_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ def check_file_attributes(datafile, was_test_run="true"):
passed=False
print(f"\N{POLICE CARS REVOLVING LIGHT} The value in HDF5 File Attribute '{expected_attr_name}' ({attr_value}) does not match the value in the filename ({base_filename}) \N{POLICE CARS REVOLVING LIGHT}")
elif expected_attr_name == "creation_timestamp":
# value from the Attribute (with a little bit of variation allowed)
attr_value = datafile.h5file.attrs.get(expected_attr_name)
date_obj = datetime.datetime.fromtimestamp((int(attr_value)/1000)-1, datetime.timezone.utc)
date_string = date_obj.strftime("%Y%m%dT%H%M%S")
Expand All @@ -125,10 +126,16 @@ def check_file_attributes(datafile, was_test_run="true"):
date_obj = datetime.datetime.fromtimestamp((int(attr_value)/1000)+0, datetime.timezone.utc)
date_string = date_obj.strftime("%Y%m%dT%H%M%S")
pattern_exact = f".*{date_string}.*"
if not re.match(pattern_exact, base_filename) and not re.match(pattern_low, base_filename) and not re.match(pattern_high, base_filename):
passed=False
print(f"\N{POLICE CARS REVOLVING LIGHT} The value in HDF5 File Attribute '{expected_attr_name}' ({date_string}) does not match the value in the filename ({base_filename}) \N{POLICE CARS REVOLVING LIGHT}")
print(f"\N{POLICE CARS REVOLVING LIGHT} Debug information: pattern_low={pattern_low} pattern_high={pattern_high} pattern_exact={pattern_exact} \N{POLICE CARS REVOLVING LIGHT}")
# 05-Feb-2026, KAB: added code to check if the unique substring based on the current date/time
# exists in the filename exists before we do any checking.
pattern = r"_\d+T\d+"
match_obj = re.search(pattern, base_filename)
if match_obj:
filename_value = re.sub('_','',match_obj.group(0))
if not re.match(pattern_exact, filename_value) and not re.match(pattern_low, filename_value) and not re.match(pattern_high, filename_value):
passed=False
print(f"\N{POLICE CARS REVOLVING LIGHT} The value in HDF5 File Attribute '{expected_attr_name}' ({date_string}) does not match the value in the filename ({base_filename}) \N{POLICE CARS REVOLVING LIGHT}")
print(f"\N{POLICE CARS REVOLVING LIGHT} Debug information: pattern_low={pattern_low} pattern_high={pattern_high} pattern_exact={pattern_exact} filename_value={filename_value} \N{POLICE CARS REVOLVING LIGHT}")
elif expected_attr_name == "run_was_for_test_purposes":
# value from the Attribute
attr_value = datafile.h5file.attrs.get(expected_attr_name)
Expand Down