Skip to content

Fix GitHub Actions workflows and documentation after Dockerfile consolidation #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcpunk merged 2 commits into from
Jan 2, 2026
Merged

Fix GitHub Actions workflows and documentation after Dockerfile consolidation #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8345f15
Initial plan
Copilot Jan 2, 2026
6bc6b6c
Fix GitHub Actions workflows to specify Dockerfile paths and update d…
Copilot Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build_docker_dependencies_image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ jobs:
uses: docker/build-push-action@v3
with:
context: ${{ github.workspace }}/microservices/
file: ${{ github.workspace }}/microservices/dockerfiles/Dockerfile.dependencies
push: true
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
1 change: 1 addition & 0 deletions .github/workflows/build_docker_image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ jobs:
uses: docker/build-push-action@v3
with:
context: ${{ github.workspace }}/microservices/
file: ${{ github.workspace }}/microservices/dockerfiles/Dockerfile
push: true
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
4 changes: 2 additions & 2 deletions docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ docker run --rm -e MICROSERVICE=<name of microservice> ghcr.io/dune-daq/microser
```

There are a couple of points to note:
* The value of MICROSERVICE should be the name of a given microservice's subdirectory in this repo. As of Jul-25-2024, the available subdirectories are: `config-service`, `elisa-logbook`, `ers-dbwriter`, `ers-protobuf-dbwriter`, `opmon-dbwriter` (now deprecated), `opmon-protobuf-dbwriter`, `runnumber-rest` and `runregistry-rest`.
* The value of MICROSERVICE should be the name of a given microservice's subdirectory in this repo. As of Jan-2-2026, the available subdirectories are: `elisa-logbook`, `ers-protobuf-dbwriter`, `opmon-protobuf-dbwriter`, `runnumber-rest` and `runregistry-rest`.
* Most microservices require additional environment variables to be set, which can be passed using the usual docker syntax: `-e VARIABLE_NAME=<variable value>`
* If you don't know what these additional environment variables are, you can just run the `docker` command as above without setting them; the container will exit out almost immediately but only after telling you what variables are missing
* The microservices image tag will be `microservices:<name-of-branch>` or `microservices:<version-tag>`, i.e. `microservices:develop`.
Expand All @@ -29,7 +29,7 @@ docker push ghcr.io/dune-daq/microservices:user-my-branch
and

```bash
docker build -f dockerfiles/Dockerfile.dependencies -t ghcr.io/dune-daq/microservices_dependencies:user-my-branch /dockerfiles
docker build -f dockerfiles/Dockerfile.dependencies -t ghcr.io/dune-daq/microservices_dependencies:user-my-branch ./dockerfiles

docker push ghcr.io/dune-daq/microservices_dependencies:user-my-branch
```
Expand Down