Conversation
…GAr_ReducedSample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request description
Previously, SampleHandlerBeamNDGAr required two inputs - a GENIE file and a very large FastGArSim output file. This FastGArSim file contained lots of hit-level information necessary for the acceptance calculation. Now a separate preprocessing script processes both inputs and produces a much reduced file, with only what is necessary extracted from the hit-level information. Reduces input file size by a factor ~100. The SampleHandlerBeamNDGAr class is now restructured to take these reduced inputs.
Note that this branch also contains the changes from PR #107 so should be merged after that one.