refactor: complete LocaleSmith rename and compatibility migration - #2
Merged
Conversation
DZXH-TX
marked this pull request as ready for review
August 10, 2026 14:12
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return true; | ||
| } | ||
| catch (IOException) when (!overwrite && File.Exists(_filePath)) | ||
| { |
There was a problem hiding this comment.
Pull request overview
Completes the repository-wide JaxI18n-to-LocaleSmith rename, adds backward-compatible state migration, updates native/package identities, and fixes WinUI theme synchronization.
Changes:
- Renames .NET, Rust, ABI, MSIX, MCP, and workspace identities.
- Migrates legacy configuration, credentials, paths, and translation memory.
- Synchronizes WinUI navigation and title-bar themes.
Reviewed changes
Copilot reviewed 210 out of 227 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/LocaleSmith.Presentation.Tests/OutputPathAndSettingsTests.cs |
Updates namespaces and paths. |
tests/LocaleSmith.Presentation.Tests/OnboardingAndShellTests.cs |
Updates test namespaces. |
tests/LocaleSmith.Presentation.Tests/ModelSourcesViewModelTests.cs |
Updates test namespaces. |
tests/LocaleSmith.Presentation.Tests/LocaleSmith.Presentation.Tests.csproj |
Updates project reference. |
tests/LocaleSmith.Presentation.Tests/DashboardViewModelTests.cs |
Updates test namespaces. |
tests/LocaleSmith.Presentation.Tests/CliConfirmationViewModelTests.cs |
Updates namespaces and audit path. |
tests/LocaleSmith.Presentation.Tests/AssistantViewModelTests.cs |
Updates test namespaces. |
tests/LocaleSmith.NativeInterop.Tests/NativeCoreClientTests.cs |
Renames native test namespace/path. |
tests/LocaleSmith.NativeInterop.Tests/LocaleSmith.NativeInterop.Tests.csproj |
Updates native project and DLL. |
tests/LocaleSmith.Mcp.Tests/McpStdioServerTests.cs |
Updates MCP test namespaces. |
tests/LocaleSmith.Mcp.Tests/McpModelToolExecutorTests.cs |
Updates MCP test namespaces. |
tests/LocaleSmith.Mcp.Tests/LocaleSmith.Mcp.Tests.csproj |
Updates MCP references. |
tests/LocaleSmith.Infrastructure.Tests/TerminalEnvironmentTests.cs |
Updates infrastructure namespaces. |
tests/LocaleSmith.Infrastructure.Tests/TemporaryDirectory.cs |
Renames test temp path. |
tests/LocaleSmith.Infrastructure.Tests/SafeCliTests.cs |
Updates CLI identity assertions. |
tests/LocaleSmith.Infrastructure.Tests/ModelAdapterTests.cs |
Updates model namespaces. |
tests/LocaleSmith.Infrastructure.Tests/MigratingSecretStoreTests.cs |
Tests credential migration and tombstones. |
tests/LocaleSmith.Infrastructure.Tests/LocaleSmith.Infrastructure.Tests.csproj |
Updates infrastructure references. |
tests/LocaleSmith.Infrastructure.Tests/EncryptedConfigurationStoreTests.cs |
Tests non-overwrite and legacy AAD. |
tests/LocaleSmith.Core.Tests/ModelToolContractTests.cs |
Updates core test namespace. |
tests/LocaleSmith.Core.Tests/ModelServiceRegistryTests.cs |
Updates core test namespace. |
tests/LocaleSmith.Core.Tests/ModelProviderPresetTests.cs |
Updates core test namespace. |
tests/LocaleSmith.Core.Tests/LocaleSmith.Core.Tests.csproj |
Updates core reference. |
tests/LocaleSmith.Core.Tests/IncrementalTranslationPlannerTests.cs |
Updates core test namespace. |
tests/LocaleSmith.Core.Tests/CliCommandTests.cs |
Updates core test namespace. |
tests/LocaleSmith.CliProbe/Program.cs |
Renames probe namespace. |
tests/LocaleSmith.CliProbe/LocaleSmith.CliProbe.csproj |
Renames probe assembly. |
tests/LocaleSmith.Archive.Tests/TestArchiveScanner.cs |
Updates archive namespaces. |
tests/LocaleSmith.Archive.Tests/SafeSubsetExternalizationPipelineTests.cs |
Updates namespaces and temp paths. |
tests/LocaleSmith.Archive.Tests/MojangComponentLiteralClassFileRewriterTests.cs |
Updates archive test namespace. |
tests/LocaleSmith.Archive.Tests/LocaleSmith.Archive.Tests.csproj |
Updates archive project and DLL. |
tests/LocaleSmith.Archive.Tests/FolderFixture.cs |
Renames fixture temp path. |
tests/LocaleSmith.Archive.Tests/ClassFileFixtureBuilder.cs |
Updates fixture namespace. |
tests/LocaleSmith.Archive.Tests/ArchiveWorkspaceBackendTests.cs |
Updates namespaces and workspace paths. |
tests/LocaleSmith.Archive.Tests/ArchiveFixture.cs |
Renames fixture temp path. |
tests/LocaleSmith.Application.Tests/TranslationPipelineTests.cs |
Updates namespaces and test paths. |
tests/LocaleSmith.Application.Tests/TranslationMemoryKeyTests.cs |
Tests legacy memory identity. |
tests/LocaleSmith.Application.Tests/ModelTranslationEngineTests.cs |
Updates application namespaces. |
tests/LocaleSmith.Application.Tests/ModelToolOrchestratorTests.cs |
Updates application namespaces. |
tests/LocaleSmith.Application.Tests/LocaleSmith.Application.Tests.csproj |
Updates application references. |
tests/LocaleSmith.App.Tests/SecureAppStateServiceTests.cs |
Tests default-path migration. |
tests/LocaleSmith.App.Tests/PipelineTranslationQueueServiceTests.cs |
Updates queue paths/namespaces. |
tests/LocaleSmith.App.Tests/ModelAssistantServiceTests.cs |
Updates app namespaces and paths. |
tests/LocaleSmith.App.Tests/LocaleSmith.App.Tests.csproj |
Updates app references. |
tests/LocaleSmith.App.Tests/LegacyAppDataMigratorTests.cs |
Tests state migration and preservation. |
tests/LocaleSmith.App.Tests/LegacyAppDataLocatorTests.cs |
Tests legacy root discovery safety. |
tests/LocaleSmith.App.Tests/FileTranslationMemoryStoreMigrationTests.cs |
Tests legacy cache copying. |
src/LocaleSmith.Presentation/ViewModels/ViewModelBase.cs |
Renames presentation namespace. |
src/LocaleSmith.Presentation/ViewModels/ShellViewModel.cs |
Renames presentation namespace. |
src/LocaleSmith.Presentation/ViewModels/SettingsViewModel.cs |
Renames presentation namespace. |
src/LocaleSmith.Presentation/ViewModels/OnboardingViewModel.cs |
Renames presentation namespace. |
src/LocaleSmith.Presentation/ViewModels/ModelSourcesViewModel.cs |
Renames presentation namespace. |
src/LocaleSmith.Presentation/ViewModels/DashboardViewModel.cs |
Renames presentation namespace. |
src/LocaleSmith.Presentation/ViewModels/CliConfirmationViewModel.cs |
Renames CLI view-model types. |
src/LocaleSmith.Presentation/ViewModels/AssistantViewModel.cs |
Renames presentation namespace. |
src/LocaleSmith.Presentation/Services/DefaultOutputPathStrategy.cs |
Renames presentation service. |
src/LocaleSmith.Presentation/Models/TranslationQueueModels.cs |
Renames queue model types. |
src/LocaleSmith.Presentation/Models/OnboardingModelPath.cs |
Renames model namespace. |
src/LocaleSmith.Presentation/Models/AppConfiguration.cs |
Renames configuration namespace. |
src/LocaleSmith.Presentation/Models/AnimationPreferencePolicy.cs |
Renames policy namespace. |
src/LocaleSmith.Presentation/LocaleSmith.Presentation.csproj |
Defines renamed presentation project. |
src/LocaleSmith.Presentation/Abstractions/PresentationServices.cs |
Renames presentation contracts. |
src/LocaleSmith.NativeInterop/NativeMethods.cs |
Defines LocaleSmith P/Invoke ABI. |
src/LocaleSmith.NativeInterop/NativeCoreLibraryResolver.cs |
Resolves renamed native DLL. |
src/LocaleSmith.NativeInterop/NativeCoreException.cs |
Renames exception namespace. |
src/LocaleSmith.NativeInterop/NativeCoreErrorCode.cs |
Renames error-code namespace. |
src/LocaleSmith.NativeInterop/NativeCoreClient.cs |
Renames native client namespace. |
src/LocaleSmith.NativeInterop/LocaleSmith.NativeInterop.csproj |
Renames native assembly. |
src/LocaleSmith.NativeInterop/ArchiveScanManifest.cs |
Renames manifest namespace. |
src/LocaleSmith.McpHost/Properties/PublishProfiles/win-x64.pubxml |
Adds x64 publish profile. |
src/LocaleSmith.McpHost/Program.cs |
Renames host and sandbox path. |
src/LocaleSmith.McpHost/LocaleSmith.McpHost.csproj |
Renames host assembly/references. |
src/LocaleSmith.Mcp/Protocol/JsonRpcWriter.cs |
Renames protocol namespace. |
src/LocaleSmith.Mcp/Protocol/JsonRpcParser.cs |
Renames protocol namespace. |
src/LocaleSmith.Mcp/Protocol/JsonRpcModels.cs |
Renames protocol namespace. |
src/LocaleSmith.Mcp/Protocol/FixedWindowRateLimiter.cs |
Renames protocol namespace. |
src/LocaleSmith.Mcp/Protocol/BoundedUtf8LineReader.cs |
Renames protocol namespace. |
src/LocaleSmith.Mcp/OutputSanitizer.cs |
Renames MCP namespace. |
src/LocaleSmith.Mcp/McpToolCatalog.cs |
Renames MCP catalog types. |
src/LocaleSmith.Mcp/McpStdioServer.cs |
Renames MCP server identity. |
src/LocaleSmith.Mcp/McpServerOptions.cs |
Renames options namespace. |
src/LocaleSmith.Mcp/McpModelToolExecutor.cs |
Renames executor namespace. |
src/LocaleSmith.Mcp/LocaleSmith.Mcp.csproj |
Updates MCP core reference. |
src/LocaleSmith.Infrastructure/Security/WindowsCredentialSecretStore.cs |
Changes credential prefix. |
src/LocaleSmith.Infrastructure/Security/SecurityOperationLock.cs |
Adds cross-process security lock. |
src/LocaleSmith.Infrastructure/Security/MigratingSecretStore.cs |
Adds lazy credential migration. |
src/LocaleSmith.Infrastructure/Security/InMemorySecretStore.cs |
Renames security namespace. |
src/LocaleSmith.Infrastructure/Security/EncryptedJsonConfigurationStore.cs |
Adds AAD selection and save-if-absent. |
src/LocaleSmith.Infrastructure/Security/CredentialManagerMasterKeyStore.cs |
Adds cross-process key creation lock. |
src/LocaleSmith.Infrastructure/Models/SafeModelHttpClientFactory.cs |
Renames model namespace. |
src/LocaleSmith.Infrastructure/Models/OpenAiCompatibleModelService.cs |
Renames model service namespace. |
src/LocaleSmith.Infrastructure/Models/OllamaModelService.cs |
Renames model service namespace. |
src/LocaleSmith.Infrastructure/Models/HttpModelServiceBase.cs |
Renames model service namespace. |
src/LocaleSmith.Infrastructure/Models/AnthropicModelService.cs |
Renames model service namespace. |
src/LocaleSmith.Infrastructure/LocaleSmith.Infrastructure.csproj |
Updates reference and test visibility. |
src/LocaleSmith.Infrastructure/Environment/TerminalEnvironmentDetector.cs |
Renames environment namespace. |
src/LocaleSmith.Infrastructure/Environment/SafeSystemPromptContextProvider.cs |
Renames environment namespace. |
src/LocaleSmith.Infrastructure/Cli/WindowsRestrictedProcessLauncher.cs |
Renames private desktop identity. |
src/LocaleSmith.Infrastructure/Cli/WindowsProcessJob.cs |
Renames CLI namespace. |
src/LocaleSmith.Infrastructure/Cli/WindowsPrivilegeContext.cs |
Renames CLI namespace. |
src/LocaleSmith.Infrastructure/Cli/TrustedCliExecutableDiscovery.cs |
Renames CLI namespace. |
src/LocaleSmith.Infrastructure/Cli/SafeCliRunner.cs |
Renames CLI namespace. |
src/LocaleSmith.Infrastructure/Cli/SafeCliCommandPolicy.cs |
Renames CLI namespace. |
src/LocaleSmith.Infrastructure/Cli/RestrictedProcessContracts.cs |
Renames CLI contracts. |
src/LocaleSmith.Infrastructure/Cli/JsonLinesCliAuditSink.cs |
Renames audit namespace. |
src/LocaleSmith.Infrastructure/Cli/CliApprovalService.cs |
Renames approval namespace. |
src/LocaleSmith.Core/Services/ModelServiceRegistry.cs |
Renames core service namespace. |
src/LocaleSmith.Core/Services/IncrementalTranslationPlanner.cs |
Renames core service namespace. |
src/LocaleSmith.Core/Models/TranslationModels.cs |
Renames core model namespace. |
src/LocaleSmith.Core/Models/TerminalEnvironmentContext.cs |
Renames core model namespace. |
src/LocaleSmith.Core/Models/SecretValue.cs |
Renames secret model namespace. |
src/LocaleSmith.Core/Models/ModelToolModels.cs |
Renames tool model namespace. |
src/LocaleSmith.Core/Models/ModelSource.cs |
Renames source model namespace. |
src/LocaleSmith.Core/Models/ModelServiceException.cs |
Renames exception namespace. |
src/LocaleSmith.Core/Models/ModelResponse.cs |
Renames response namespace. |
src/LocaleSmith.Core/Models/ModelRequest.cs |
Renames request namespace. |
src/LocaleSmith.Core/Models/ModelProviderPreset.cs |
Renames preset namespace. |
src/LocaleSmith.Core/Models/ModelProviderKind.cs |
Renames provider namespace. |
src/LocaleSmith.Core/Models/ModelMessage.cs |
Renames message namespace. |
src/LocaleSmith.Core/Models/CliModels.cs |
Renames CLI model namespace. |
src/LocaleSmith.Core/Models/AvailableModelInfo.cs |
Renames model namespace. |
src/LocaleSmith.Core/LocaleSmith.Core.csproj |
Defines renamed core project. |
src/LocaleSmith.Core/Abstractions/TerminalEnvironmentContracts.cs |
Renames environment contracts. |
src/LocaleSmith.Core/Abstractions/SecretContracts.cs |
Renames secret contracts. |
src/LocaleSmith.Core/Abstractions/IModelServiceRegistry.cs |
Renames registry contract. |
src/LocaleSmith.Core/Abstractions/IModelService.cs |
Renames model contract. |
src/LocaleSmith.Core/Abstractions/CliContracts.cs |
Renames CLI contracts. |
src/LocaleSmith.Archive/TransactionJournal.cs |
Renames archive namespace. |
src/LocaleSmith.Archive/LocaleSmith.Archive.csproj |
Defines renamed archive project. |
src/LocaleSmith.Archive/LangResourceEditor.cs |
Renames archive namespace. |
src/LocaleSmith.Archive/JsonResourceEditor.cs |
Renames archive namespace. |
src/LocaleSmith.Archive/IArchiveScanner.cs |
Renames scanner contract. |
src/LocaleSmith.Archive/FolderSnapshotBuilder.cs |
Renames archive namespace. |
src/LocaleSmith.Archive/ClassFile/ParsedClassFile.cs |
Renames class-file namespace. |
src/LocaleSmith.Archive/ClassFile/MojangComponentLiteralClassFileRewriter.cs |
Renames class-file namespace. |
src/LocaleSmith.Archive/ClassFile/JavaBytecodeDecoder.cs |
Renames class-file namespace. |
src/LocaleSmith.Archive/ClassFile/ClassFileRewriteModels.cs |
Renames class-file namespace. |
src/LocaleSmith.Archive/ClassFile/ClassFileBinary.cs |
Renames class-file namespace. |
src/LocaleSmith.Archive/ArchiveWorkspaceOptions.cs |
Renames archive namespace. |
src/LocaleSmith.Archive/ArchiveWorkspaceBackend.cs |
Renames workspace temp root. |
src/LocaleSmith.Archive/ArchiveWorkspace.cs |
Renames archive dependencies. |
src/LocaleSmith.Archive/ArchivePathSafety.cs |
Renames archive namespace. |
src/LocaleSmith.Archive/ArchiveEntrySnapshot.cs |
Renames archive namespace. |
src/LocaleSmith.Application/TranslationContractException.cs |
Renames application namespace. |
src/LocaleSmith.Application/Services/TranslationPipeline.cs |
Renames pipeline dependencies. |
src/LocaleSmith.Application/Services/TranslationJsonModels.cs |
Renames service namespace. |
src/LocaleSmith.Application/Services/PlaceholderValidator.cs |
Renames service namespace. |
src/LocaleSmith.Application/Services/PipelineQueue.cs |
Renames queue namespace. |
src/LocaleSmith.Application/Services/PipelineJobHandle.cs |
Renames job namespace. |
src/LocaleSmith.Application/Services/ModelTranslationEngineOptions.cs |
Renames options namespace. |
src/LocaleSmith.Application/Services/ModelTranslationEngine.cs |
Renames engine dependencies. |
src/LocaleSmith.Application/Services/ModelToolOrchestrator.cs |
Renames orchestrator namespace. |
src/LocaleSmith.Application/PipelineException.cs |
Renames pipeline exception. |
src/LocaleSmith.Application/Models/TranslationMemoryModels.cs |
Adds current and legacy cache identities. |
src/LocaleSmith.Application/Models/PipelineModels.cs |
Renames pipeline models. |
src/LocaleSmith.Application/LocaleSmith.Application.csproj |
Defines renamed application project. |
src/LocaleSmith.Application/Abstractions/ITranslationMemoryStore.cs |
Renames memory contract. |
src/LocaleSmith.Application/Abstractions/ITranslationEngine.cs |
Renames engine contract. |
src/LocaleSmith.Application/Abstractions/IPipelineJobScheduler.cs |
Renames scheduler contract. |
src/LocaleSmith.Application/Abstractions/IArchiveWorkspace.cs |
Renames workspace contracts. |
src/LocaleSmith.App/Themes/Controls.xaml |
Updates behavior namespace. |
src/LocaleSmith.App/Strings/zh-CN/Resources.resw |
Standardizes Chinese branding. |
src/LocaleSmith.App/Services/WinUiTextProvider.cs |
Renames app service namespace. |
src/LocaleSmith.App/Services/SecureAppStateService.cs |
Normalizes legacy default paths. |
src/LocaleSmith.App/Services/PipelineTranslationQueueService.cs |
Renames queue service. |
src/LocaleSmith.App/Services/ModelAssistantService.cs |
Renames assistant service. |
src/LocaleSmith.App/Services/LegacyDefaultPathNormalizer.cs |
Adds exact default-path migration. |
src/LocaleSmith.App/Services/LegacyAppDataMigrator.cs |
Migrates legacy app state. |
src/LocaleSmith.App/Services/LegacyAppDataLocator.cs |
Discovers safe legacy roots. |
src/LocaleSmith.App/Services/FileTranslationMemoryStore.cs |
Adds legacy cache-slot migration. |
src/LocaleSmith.App/Services/DispatcherQueueUiDispatcher.cs |
Renames dispatcher service. |
src/LocaleSmith.App/Services/CliConfirmationViewModelFactory.cs |
Renames factory contracts. |
src/LocaleSmith.App/Services/AppMotionService.cs |
Renames motion service. |
src/LocaleSmith.App/Properties/PublishProfiles/win-x64.pubxml |
Adds x64 publish profile. |
src/LocaleSmith.App/Pages/SettingsPage.xaml.cs |
Renames settings code-behind. |
src/LocaleSmith.App/Pages/SettingsPage.xaml |
Renames settings XAML types. |
src/LocaleSmith.App/Pages/OnboardingPage.xaml.cs |
Renames onboarding code-behind. |
src/LocaleSmith.App/Pages/OnboardingPage.xaml |
Renames onboarding XAML types. |
src/LocaleSmith.App/Pages/ModelSourcesPage.xaml.cs |
Renames model-source code-behind. |
src/LocaleSmith.App/Pages/ModelSourcesPage.xaml |
Renames model-source XAML types. |
src/LocaleSmith.App/Pages/DashboardPage.xaml.cs |
Renames dashboard code-behind. |
src/LocaleSmith.App/Pages/DashboardPage.xaml |
Renames dashboard XAML types. |
src/LocaleSmith.App/Pages/AssistantPage.xaml.cs |
Renames assistant code-behind. |
src/LocaleSmith.App/Pages/AssistantPage.xaml |
Renames assistant XAML types. |
src/LocaleSmith.App/MainWindow.xaml.cs |
Fixes theme/chrome synchronization. |
src/LocaleSmith.App/MainWindow.xaml |
Updates window branding/types. |
src/LocaleSmith.App/LocaleSmith.App.csproj |
Defines renamed WinUI app. |
src/LocaleSmith.App/Dialogs/CliConfirmationDialog.xaml.cs |
Renames dialog code-behind. |
src/LocaleSmith.App/Dialogs/CliConfirmationDialog.xaml |
Renames dialog XAML types. |
src/LocaleSmith.App/Converters/BooleanToVisibilityConverter.cs |
Renames converter namespace. |
src/LocaleSmith.App/Behaviors/AppMotion.cs |
Renames behavior namespace. |
src/LocaleSmith.App/App.xaml.cs |
Integrates migration and new DI stores. |
src/LocaleSmith.App/App.xaml |
Renames application XAML types. |
src/LocaleSmith.App/app.manifest |
Renames assembly identity. |
src/JaxI18n.Presentation/JaxI18n.Presentation.csproj |
Removes old presentation project. |
src/JaxI18n.NativeInterop/NativeMethods.cs |
Removes old native ABI projection. |
src/JaxI18n.Archive/JaxI18n.Archive.csproj |
Removes old archive project. |
src/JaxI18n.Application/JaxI18n.Application.csproj |
Removes old application project. |
src/JaxI18n.App/JaxI18n.App.csproj |
Removes old WinUI project. |
README.md |
Updates branding, paths, and build guidance. |
packaging/LocaleSmith.Package/Strings/zh-CN/Resources.resw |
Updates Chinese package branding. |
packaging/LocaleSmith.Package/Strings/en-US/Resources.resw |
Updates publisher branding. |
packaging/LocaleSmith.Package/Package.appxmanifest |
Updates package identity/runtime dependency. |
packaging/LocaleSmith.Package/LocaleSmith.Package.wapproj |
Updates package project references. |
packaging/LocaleSmith.Package/Assets/StoreLogo.png |
Adds renamed store logo. |
packaging/LocaleSmith.Package/Assets/Square44x44Logo.png |
Adds renamed application logo. |
package.json |
Renames npm workspace package. |
native/localesmith_core/tests/archive_scan.rs |
Renames Rust crate and ABI tests. |
native/localesmith_core/src/metadata.rs |
Adds renamed metadata implementation. |
native/localesmith_core/src/lib.rs |
Updates crate documentation. |
native/localesmith_core/src/ffi.rs |
Renames exported C ABI. |
native/localesmith_core/src/error.rs |
Adds renamed error definitions. |
native/localesmith_core/include/localesmith_core.h |
Defines renamed public C header. |
native/localesmith_core/Cargo.toml |
Renames Rust crate/library. |
native/localesmith_core/Cargo.lock |
Updates locked crate identity. |
native/localesmith_core/.gitignore |
Ignores Rust build output. |
native/jax_i18n_core/include/jax_i18n_core.h |
Removes old C header. |
LocaleSmith.slnx |
Defines renamed solution. |
JaxI18n.slnx |
Removes old solution. |
Suppressed comments (1)
src/LocaleSmith.App/Services/FileTranslationMemoryStore.cs:55
- If another process creates or updates the LocaleSmith slot after
sourcePathis selected,CopyFileAtomicallyAsynctreats the failed move as a successful idempotent migration, but this method still returns the stale legacy snapshot. The pipeline can then merge from that stale state and later overwrite the newer slot, losing cached translations. When the destination wins the race, reload and return the destination snapshot (or hold a cross-process lock across selection, copy, and read).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8fd63df55
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
| await using var scheduler = new RecordingScheduler(); | ||
| var service = new PipelineTranslationQueueService(scheduler); | ||
| var outputDirectory = Path.GetDirectoryName(outputPath)!; | ||
| Assert.False(Directory.Exists(outputDirectory)); |
| TestContext.Current.CancellationToken); | ||
| var result = await handle.Completion.WaitAsync(TestContext.Current.CancellationToken); | ||
|
|
||
| Assert.False(Directory.Exists(outputDirectory)); |
| OpenAiTokenLimitParameter.MaxCompletionTokens, | ||
| harness.Registry.Sources.Single().TokenLimitParameter); | ||
| Assert.Equal(directories.LogDirectoryPath, configurationStore.Persisted.LogDirectoryPath); | ||
| Assert.True(Directory.Exists(directories.LogDirectoryPath)); |
| Path.GetTempPath(), | ||
| "LocaleSmith.Tests", | ||
| Guid.NewGuid().ToString("N")); | ||
| Directory.CreateDirectory(testRoot); |
| Assert.True(await settings.FlushPendingChangesAsync(cancellationToken)); | ||
| } | ||
|
|
||
| var encryptedBytes = await File.ReadAllTextAsync(configurationPath, cancellationToken); |
| await workspace.DisposeAsync(); | ||
| } | ||
|
|
||
| Assert.False(Directory.Exists(workspacePath)); |
|
|
||
| Assert.False(Directory.Exists(workspacePath)); | ||
| File.Move(journalPath, renamedJournal); | ||
| Assert.True(File.Exists(renamedJournal)); |
| }); | ||
| writerField.SetValue(journal, failingWriter); | ||
| originalWriter.Dispose(); | ||
|
|
|
|
||
| await Assert.ThrowsAsync<InvalidDataException>( | ||
| () => workspace.StagePackageAsync( | ||
| request.OutputPath, |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 238 out of 254 changed files in this pull request and generated no new comments.
Suppressed comments (1)
packaging/LocaleSmith.Package/Package.appxmanifest:9
- Changing both
Identity.NameandPublishercreates a different package family ({PackageName}_{publisherId}), so this package cannot upgrade the existingJaxI18n.Desktopinstallation in place; Windows installs it side-by-side and leaves the old app registered. This conflicts with the PR's upgrade claim. Preserve the existing package identity and rebrand only display resources if an in-place upgrade is required, or explicitly document and handle side-by-side replacement/cleanup if the new identity is intentional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
完成从 JaxI18n 到 LocaleSmith 的全仓库品牌、技术标识、原生 ABI、打包身份与兼容迁移改造，并修复 WinUI 三种主题下导航窗格颜色不同步的问题。
本 PR 共包含 227 个文件变更（2497 行新增、812 行删除）。旧名称只保留在读取旧数据、旧凭据和旧格式所必需的兼容路径及其测试中。
更新项
1. 产品品牌与显示名称
LocaleSmith | 译匠。LocaleSmith。localesmith-mcp，标题改为LocaleSmith Local Tools。@localesmith/workspace。2. .NET 项目与命名空间
JaxI18n.slnx重命名为LocaleSmith.slnx。LocaleSmith.*。3. Rust、DLL 与 C ABI
native/jax_i18n_core重命名为native/localesmith_core。localesmith_core。localesmith_core.h。jax_i18n_*全部迁移到localesmith_*。localesmith_error_code与LOCALESMITH_*。localesmith_core.dll。4. MSIX 与 SignPath
packaging/LocaleSmith.Package，WAP 工程改为LocaleSmith.Package.wapproj。LocaleSmith.Desktop，版本为0.1.0.2，架构为 x64。5. 旧配置、凭据和加密数据迁移
%LOCALAPPDATA%\LocaleSmith。JaxI18n.DesktopPFN，不硬编码 Publisher hash。Packages\<PFN>\LocalCache\Local\JaxI18n，保留 unpackaged%LOCALAPPDATA%\JaxI18nfallback。settings.jaxcfg，绝不覆盖现有settings.localesmithcfg。LocaleSmith.ApplicationSettings.v1，AAD 改为LocaleSmith.Config；旧 purpose/AAD 仅用于兼容解密。SaveIfAbsentAsync，降低多实例迁移覆盖风险。LocaleSmith；缺失时从旧JaxI18n存储懒迁移。localesmith.translation-memory/v2，可从旧 schema/槽位读取并原子复制，旧数据不删除。Documents\JaxI18n到Documents\LocaleSmith，Temp\JaxI18n\Sandbox到Temp\LocaleSmith\Sandbox。JaxI18n字样也保持不变。6. System / Light / Dark 主题修复
7. 测试与文档
根因
验证
dotnet build LocaleSmith.slnx -c Release --no-restore：0 警告、0 错误。dotnet test LocaleSmith.slnx -c Release --no-build --no-restore：282/282 通过。-D warnings）、release build：通过。安全与仓库卫生
bin/、obj/、Rusttarget/、AppPackages/和 SignPath 外部目录均保持忽略。用户影响