Some Fixes for Preenchanted/Bedrock Items and Enchanting#915
Open
MissBismuth wants to merge 2 commits into
Open
Some Fixes for Preenchanted/Bedrock Items and Enchanting#915MissBismuth wants to merge 2 commits into
MissBismuth wants to merge 2 commits into
Conversation
make sure you can't enchant preenchanted enchantments again make sure you can't enchant bedrock items with unbreaking
Collaborator
|
Removing enchantments from preenchanted items is very much intentional. There are advancements referencing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happened to me, not sure if all of these behaviours are intentional, but they felt weird to me, so I'm suggesting these changes.
I enchanted a bedrock pickaxe with level 30 and it gave me unbreaking (which is not needed on unbreakable tools)
I disenchanted the bedrock pickaxe to try again and it removed silk touch (I think this might be intentional, if so, I can edit this PR)
I enchanted a new bedrock pickaxe and the enchanting table wanted to give me silk touch (which was already on the pickaxe)