Repository navigation
Rkz Stamina fixes - #1575
Rkz Stamina fixes#1575Tsar-Salat wants to merge 4 commits into
Conversation
| * * paralyze : duration to paralyze src | ||
| * * overstam : If TRUE, stamina_amount will be able to deal stamina damage over the waekened threshold, allowing it to also stamina stun. | ||
| * * stack_status : Should the given status value(s) stack ontop of existing status values? | ||
| * * protection : Armor value (0-100) that reduces stamina_amount |
There was a problem hiding this comment.
Armor was handled a bit odd here, so this should make more sense.
But I may not have a good idea of what you were going for with it, so lmk if you want it to be handled differently
There was a problem hiding this comment.
You can just remove the placeholder, if/when we get a protection mechanic it'll be handled inside the proc itself.
There was a problem hiding this comment.
I guess then, would you prefer your previous logic of var/stamina = P.disorient_damage * ((100-armor_check)/100) or just.. no armor proctection at all?
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| /mob/living/proc/takes_stamina_damage() | ||
| return pre_stamina_change(-1) != 0 |
There was a problem hiding this comment.
Not really a fan of how this works. Would rather a trait or similar.
| * * paralyze : duration to paralyze src | ||
| * * overstam : If TRUE, stamina_amount will be able to deal stamina damage over the waekened threshold, allowing it to also stamina stun. | ||
| * * stack_status : Should the given status value(s) stack ontop of existing status values? | ||
| * * protection : Armor value (0-100) that reduces stamina_amount |
There was a problem hiding this comment.
You can just remove the placeholder, if/when we get a protection mechanic it'll be handled inside the proc itself.
| RegisterSignal(owner, COMSIG_LIVING_POST_FULLY_HEAL, PROC_REF(on_heal)) | ||
| if(owner.stat == DEAD) | ||
| return FALSE | ||
| if(!(owner.status_flags & CANKNOCKDOWN) || HAS_TRAIT(owner, TRAIT_STUNIMMUNE)) | ||
| return FALSE | ||
| if(owner.absorb_stun(1)) | ||
| return FALSE |
There was a problem hiding this comment.
If you want to move this to a status effect (Not a bad idea), these checks should be handled by stamina_stun() like other incapacitating status effects, since otherwise every second, stun-immune mobs would be churning status effect datums. Lots of wasted overhead.
|
This pull request conflicts with the merge target. |
This branch has not been deployed
2 participants
About The Pull Request
This is me upstreaming the relevant fixes of:
Atleast in the places where kapu and I have a similiar idea of how the system should work
The only real unwanted balance change you might not like is the armor one
Why It's Good For The Game
At 49 stamina remaining there was a 608% chance to stun a carbon, and at 0 stamina remaining that chance went to 20%.
I love algebra
Changelog
🆑 rkz/tsar-salat
fix: fixed stamina stun calculation. Carbons will no longer be more likely to be stunned with higher stamina.
code: stamcrit is now a status effect, should handle better
fix: fixed instances of stam damage healing stamina
fix: clamped armor values, fixing damaging enough bullets healing stamina
fix: fixed current stamina sometimes going above max stamina (it broke stuff)
/:cl: