Conversation
📝 WalkthroughWalkthroughThe pull request updates pinned documentation and development dependency versions. No public entities or exports changed. ChangesDependency Pin Updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: 🟡 Moderate · up to Python 3.9 CI jobs will fail while installing development dependencies, blocking the supported test workflow. Align the supported Python versions and dependency pins before merging. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
A rabbit checks each versioned line Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 273276b4-28ae-49a9-9eba-832a6b8fb534
📒 Files selected for processing (2)
docs/requirements-docs.txtrequirements-dev.txt
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.
📜 Review details
⏰ Context from checks skipped due to timeout. (4)
- GitHub Check: build (3.12)
- GitHub Check: build (3.11)
- GitHub Check: build (3.13)
- GitHub Check: build (3.10)
🔇 Additional comments (1)
requirements-dev.txt (1)
1-1: LGTM!Also applies to: 3-3, 6-6, 9-9
| pytest==8.3.5 | ||
| respx==0.22.0 | ||
| setuptools==84.0.0 | ||
| pytest==9.1.1 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n -C4 'python-version|setup-python|matrix|python:' \
.github/workflows/docs-publish.yml \
.github/workflows/python-package.yml
fd -t f | rg '(^|/)(pyproject.toml|setup.cfg|setup.py|tox.ini|noxfile.py|\.python-version|runtime.txt)$' |
xargs -r rg -n -C3 \
'requires-python|python_requires|Programming Language :: Python'Repository: DagsHub/client
Length of output: 2438
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' '--- workflow install steps ---'
sed -n '1,100p' .github/workflows/python-package.yml
sed -n '1,100p' .github/workflows/docs-publish.yml
printf '%s\n' '--- requirement files ---'
cat -n requirements-dev.txt
cat -n docs/requirements-docs.txt
printf '%s\n' '--- package metadata ---'
python3 - <<'PY'
import json
import urllib.request
packages = [
("pytest", "9.1.1"),
("pytest-env", "1.7.1"),
("fiftyone", "1.22.0"),
("datasets", "5.0.1"),
("sphinx-autodoc-typehints", "3.13.6"),
]
for name, version in packages:
url = f"https://pypi.org/pypi/{name}/{version}/json"
try:
with urllib.request.urlopen(url, timeout=15) as response:
data = json.load(response)
info = data["info"]
print(f"{name}=={version}: requires_python={info.get('requires_python')!r}")
except Exception as exc:
print(f"{name}=={version}: ERROR {exc}")
PYRepository: DagsHub/client
Length of output: 5391
🏁 Script executed:
#!/bin/bash
set -euo pipefail
python3 - <<'PY'
import json
import subprocess
packages = [
("pytest", "9.1.1"),
("pytest-env", "1.7.1"),
("fiftyone", "1.22.0"),
("datasets", "5.0.1"),
("sphinx-autodoc-typehints", "3.13.6"),
]
for name, version in packages:
url = f"https://pypi.org/pypi/{name}/{version}/json"
result = subprocess.run(
["curl", "--fail", "--silent", "--show-error", "--insecure", url],
capture_output=True,
text=True,
check=True,
)
info = json.loads(result.stdout)["info"]
print(f"{name}=={version}: requires_python={info.get('requires_python')!r}")
PYRepository: DagsHub/client
Length of output: 382
Raise the development Python floor to 3.10, or use dependency versions that support Python 3.9.
.github/workflows/python-package.yml installs requirements-dev.txt in its Python 3.9 matrix job. pytest==9.1.1, pytest-env==1.7.1, fiftyone==1.22.0, and datasets==5.0.1 require Python 3.10 or newer, so installation fails before tests. setup.py still declares Python 3.9 support. Remove Python 3.9 from the matrix and raise the project floor, or select dependency versions that support Python 3.9.
📍 Affects 2 files
requirements-dev.txt#L2-L2(this comment)requirements-dev.txt#L5-L5requirements-dev.txt#L7-L8docs/requirements-docs.txt#L7-L7
Source: MCP tools
1 participant
Update sphinx-autodoc-typehints from 3.9.9 to 3.13.6.
The bot wasn't able to find a changelog for this release. Got an idea?
Links
Update setuptools from 80.9.0 to 84.0.0.
Changelog
84.0.0
83.0.0
82.0.1
82.0.0
81.0.0
80.10.2
80.10.1
80.10.0
Links
Update pytest from 8.3.5 to 9.1.1.
Changelog
9.1.1
9.1.0
9.0.3
9.0.2
9.0.1
9.0.0
8.4.2
8.4.1
8.4.0