Skip to content

release(life-call): promote CORE 8e DAILY journey#336

Merged
Daisuke134 merged 7 commits into
mainfrom
dev
Jul 22, 2026
Merged

release(life-call): promote CORE 8e DAILY journey#336
Daisuke134 merged 7 commits into
mainfrom
dev

Conversation

@Daisuke134

@Daisuke134 Daisuke134 commented Jul 22, 2026

Copy link
Copy Markdown
Owner

Summary

  • promote the accepted CORE 8e DAILY journey through the normal dev-to-main path
  • report travel autofill only after calendar provider acceptance
  • preserve silent location_missing/on_time late-notice behavior and late dedup
  • include the production-path journey contract and omitted core suites

Verification

  • staging deployment a53bf285-b336-424d-bf85-76fd85f240e2: SUCCESS at a524de7
  • staging smoke: /health 200, SMOKE OK
  • npm test: 407/407
  • npm run eval: 33/33 (100%)

Summary by CodeRabbit

  • 新機能

    • 旅行予定の自動登録時、出発日時や移動情報を含むTelegram通知を送信するようになりました。
    • 日付・時刻を現地時間に合わせて表示し、安全にメッセージを生成します。
  • 改善

    • ヘルパー用イベントを遅延通知の判定対象から除外しました。
    • 架電失敗時の再試行や低残高通知の処理を改善しました。
  • テスト

    • 旅行登録、架電、遅延通知の一連の動作を検証するテストを追加しました。

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Daisuke134, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: ddddb553-57f7-498c-af41-e4ef11c9a86e

📥 Commits

Reviewing files that changed from the base of the PR and between a524de7 and bbceba7.

📒 Files selected for processing (2)
  • apps/life-call/scheduler.js
  • apps/life-call/test/daily-journey-contract.test.js
📝 Walkthrough

Walkthrough

旅行イベントから往路レポートを生成し、ローカル時刻とHTMLエスケープを考慮したTelegram通知を追加しました。スケジューラーの依存性注入、ヘルパーブロック除外、日次ジャーニー契約テスト、Writer Loop記録も更新しています。

Changes

日次旅行ジャーニー

Layer / File(s) Summary
旅行レポートと通知メッセージ契約
apps/life-call/lib/travel.js, apps/life-call/lib/i18n.js
旅行イベントにstartIsooutboundReportsを追加し、ローカル日時・移動時間・出発時刻を含む日本語通知生成APIを公開します。
スケジューラーと遅延通知の依存性注入
apps/life-call/scheduler.js, apps/life-call/lib/late-notice.js
旅行・架電・遅延通知の依存を差し替え可能にし、通話失敗時のclaim解放と残高アラート、ヘルパーブロック除外を追加します。
日次ジャーニー契約検証
apps/life-call/test/daily-journey-contract.test.js, apps/life-call/package.json
旅行ブロック作成、通知重複抑制、架電claim、daily poll、on_time/late通知を検証し、関連テストを実行対象に追加します。

Writer Loop記録更新

Layer / File(s) Summary
Writer Loopの証拠とタスク状態
docs/loop-engineering/47-writer-loop-quality-and-self-improvement.md
参照元とインシデント証拠を追記し、E1の証拠とE2の完了状態を更新します。

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Scheduler
  participant Calendar
  participant Travel
  participant Telegram
  Scheduler->>Travel: fillTravel()
  Travel->>Calendar: create travel block
  Calendar-->>Travel: creation result
  Travel-->>Scheduler: outboundReports
  Scheduler->>Telegram: formatted travel notification
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed life-call の CORE 8e DAILY journey を main に昇格するリリース内容と一致しており、主変更を適切に要約しています。
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
docs/loop-engineering/47-writer-loop-quality-and-self-improvement.md (1)

743-750: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

E1/E2証跡に再現可能な参照を追加してください。

テスト件数・ハッシュ・adapter外直呼び0 だけでは、どのコマンド、artifact、日時、検索範囲で確認した結果かを独立再現できません。各証跡に検証コマンド、artifact path、実行日時、grep対象範囲を併記してください。

Also applies to: 756-757

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/loop-engineering/47-writer-loop-quality-and-self-improvement.md` around
lines 743 - 750, Update the E1/E2 evidence entries in the document to include
reproducible verification details for every reported result: the exact command
used, artifact path, execution timestamp, and grep/search scope. Cover the
entries around the E1 and E2 test, probe, archive, ledger, and artifact-only
review claims, while preserving the existing counts, hashes, and conclusions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/life-call/scheduler.js`:
- Around line 296-321: In travelUserOnce, isolate each sendMessage call within
the outboundReports loop in its own try/catch so one Telegram failure does not
stop subsequent reports. Log or otherwise handle the individual notification
error, then always return the successful fillTravel result r regardless of
notification failures.

---

Nitpick comments:
In `@docs/loop-engineering/47-writer-loop-quality-and-self-improvement.md`:
- Around line 743-750: Update the E1/E2 evidence entries in the document to
include reproducible verification details for every reported result: the exact
command used, artifact path, execution timestamp, and grep/search scope. Cover
the entries around the E1 and E2 test, probe, archive, ledger, and artifact-only
review claims, while preserving the existing counts, hashes, and conclusions.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 125aa24f-8e9f-4e30-ae77-5f77fb57ffe4

📥 Commits

Reviewing files that changed from the base of the PR and between b25437f and a524de7.

📒 Files selected for processing (7)
  • apps/life-call/lib/i18n.js
  • apps/life-call/lib/late-notice.js
  • apps/life-call/lib/travel.js
  • apps/life-call/package.json
  • apps/life-call/scheduler.js
  • apps/life-call/test/daily-journey-contract.test.js
  • docs/loop-engineering/47-writer-loop-quality-and-self-improvement.md

Comment thread apps/life-call/scheduler.js
…-20260722

fix(life-call): isolate CORE 8e report failures
@railway-app
railway-app Bot temporarily deployed to Anicca / staging July 22, 2026 06:03 Inactive
@Daisuke134
Daisuke134 merged commit 85a68ab into main Jul 22, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant