Skip to content

Cleanup_examples_register_kernel #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SriramKatta wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Cleanup_examples_register_kernel #56

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8be95fd
refactor register_kernel to use type traits for integer and floating …
SriramKatta Feb 6, 2026
f0263f6
refactor: simplify template struct definitions and improve formatting…
SriramKatta Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 47 additions & 64 deletions examples/examples_common.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,74 +168,57 @@ Only type supported by this helper function at this time:
- int, long int, long long int, unsigned long long int
- float, double
*/
// TODO: Clean the mess up!
template <typename T> constexpr bool always_false_v = false;

template <typename T> struct smax_int_type {
static_assert(always_false_v<T>, "Unsupported integer type");
};

template <> struct smax_int_type<int> {
static constexpr SMAX::IntType value = SMAX::IntType::INT32;
};

template <> struct smax_int_type<unsigned int> {
static constexpr SMAX::IntType value = SMAX::IntType::UINT32;
};

template <> struct smax_int_type<long> {
static constexpr SMAX::IntType value = SMAX::IntType::INT64;
};

template <> struct smax_int_type<long long> {
static constexpr SMAX::IntType value = SMAX::IntType::INT64;
};

template <> struct smax_int_type<unsigned long long> {
static constexpr SMAX::IntType value = SMAX::IntType::UINT64;
};

template <typename T> struct smax_float_type {
static_assert(always_false_v<T>, "Unsupported integer type");
};

template <> struct smax_float_type<float> {
static constexpr SMAX::FloatType value = SMAX::FloatType::FLOAT32;
};

template <> struct smax_float_type<double> {
static constexpr SMAX::FloatType value = SMAX::FloatType::FLOAT64;
};

template <typename IT, typename VT>
void register_kernel(SMAX::Interface *smax, std::string kernel_name,
SMAX::KernelType KernelType,
SMAX::PlatformType PlatformType) {
if constexpr (std::is_same_v<IT, int>) {
if constexpr (std::is_same_v<VT, float>) {
smax->register_kernel(kernel_name.c_str(), KernelType, PlatformType,
SMAX::IntType::INT32,
SMAX::FloatType::FLOAT32);
} else if constexpr (std::is_same_v<VT, double>) {
smax->register_kernel(kernel_name.c_str(), KernelType, PlatformType,
SMAX::IntType::INT32,
SMAX::FloatType::FLOAT64);
} else {
std::cout << "VT not recognized" << std::endl;
}
} else if constexpr (std::is_same_v<IT, long>) {
if constexpr (std::is_same_v<VT, float>) {
smax->register_kernel(kernel_name.c_str(), KernelType, PlatformType,
SMAX::IntType::INT64,
SMAX::FloatType::FLOAT32);
} else if constexpr (std::is_same_v<VT, double>) {
smax->register_kernel(kernel_name.c_str(), KernelType, PlatformType,
SMAX::IntType::INT64,
SMAX::FloatType::FLOAT64);
} else {
std::cout << "VT not recognized" << std::endl;
}
} else if constexpr (std::is_same_v<IT, unsigned int>) {
if constexpr (std::is_same_v<VT, float>) {
smax->register_kernel(kernel_name.c_str(), KernelType, PlatformType,
SMAX::IntType::UINT32,
SMAX::FloatType::FLOAT32);
} else if constexpr (std::is_same_v<VT, double>) {
smax->register_kernel(kernel_name.c_str(), KernelType, PlatformType,
SMAX::IntType::UINT32,
SMAX::FloatType::FLOAT64);
} else {
std::cout << "VT not recognized" << std::endl;
}
} else if constexpr (std::is_same_v<IT, long long>) {
if constexpr (std::is_same_v<VT, float>) {
smax->register_kernel(kernel_name.c_str(), KernelType, PlatformType,
SMAX::IntType::INT64,
SMAX::FloatType::FLOAT32);
} else if constexpr (std::is_same_v<VT, double>) {
smax->register_kernel(kernel_name.c_str(), KernelType, PlatformType,
SMAX::IntType::INT64,
SMAX::FloatType::FLOAT64);
} else {
std::cout << "VT not recognized" << std::endl;
}
} else if constexpr (std::is_same_v<IT, unsigned long long>) {
if constexpr (std::is_same_v<VT, float>) {
smax->register_kernel(kernel_name.c_str(), KernelType, PlatformType,
SMAX::IntType::UINT64,
SMAX::FloatType::FLOAT32);
} else if constexpr (std::is_same_v<VT, double>) {
smax->register_kernel(kernel_name.c_str(), KernelType, PlatformType,
SMAX::IntType::UINT64,
SMAX::FloatType::FLOAT64);
} else {
std::cout << "VT not recognized" << std::endl;
}
} else {
std::cout << "IT not recognized" << std::endl;
}
static_assert(std::is_integral_v<IT>, "IT must be an integral type");
static_assert(std::is_floating_point_v<VT>,
"VT must be a floating point type");

constexpr SMAX::IntType itype = smax_int_type<IT>::value;
constexpr SMAX::FloatType ftype = smax_float_type<VT>::value;

smax->register_kernel(kernel_name.c_str(), KernelType, PlatformType, itype,
ftype);
};

double compute_euclid_dist(const ULL n_rows, const double *y_SMAX,
Expand Down