Skip to content

Fix Passthrough nodes defaulting to simplified view #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Olipro merged 1 commit into from
May 21, 2026
Merged

Fix Passthrough nodes defaulting to simplified view #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Foreman/Models/Nodes/PassthroughNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public enum Errors {
public bool SimpleDraw { get; set; }
public PassthroughNode(ProductionGraph graph, int nodeID, ItemQualityPair item) : base(graph, nodeID) {
PassthroughItem = item;
SimpleDraw = true;
SimpleDraw = graph.DefaultToSimplePassthroughNodes;
controller = new PassthroughNodeController(this);
}

Expand Down
15 changes: 15 additions & 0 deletions ForemanTest/ItemQualityNodeDiagnosticsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using ForemanTest.support;
using Microsoft.VisualStudio.TestTools.UnitTesting;
using System;
using System.Drawing;
using System.Linq;

namespace ForemanTest {
Expand Down Expand Up @@ -77,6 +78,20 @@ public void Passthrough_ToString_DescribesPassthroughNode() {
Assert.IsFalse(node.ToString().StartsWith("Supply node", StringComparison.Ordinal));
}

[TestMethod]
public void Passthrough_NewNode_UsesGraphDefaultSimpleDraw() {
var ctx = GraphSessionTestHelper.CreateContext();
var graph = ctx.NewGraph();

graph.DefaultToSimplePassthroughNodes = false;
PassthroughNode plain = graph.CreatePassthroughNode(ctx.Item("belt"), Point.Empty);
Assert.IsFalse(plain.SimpleDraw);

graph.DefaultToSimplePassthroughNodes = true;
PassthroughNode simplified = graph.CreatePassthroughNode(ctx.Item("iron"), Point.Empty);
Assert.IsTrue(simplified.SimpleDraw);
}

[TestMethod]
public void Spoil_ToString_IncludesInputOutputAndQualities() {
var ctx = GraphSessionTestHelper.CreateContext();
Expand Down
Loading