Open
Conversation
DanilWeda
force-pushed
the
TDA-5-create-first-components
branch
from
4300a1e to
f8ba6a5
Compare
DanilWeda
force-pushed
the
TDA-5-create-first-components
branch
from
f8ba6a5 to
dff13e4
Compare
Comment on lines
+13
to
+14
| --minWidth: 700px; | ||
| --minHeight: 300px; |
Collaborator
There was a problem hiding this comment.
why do you need those --
Comment on lines
+50
to
+52
| border: 1px solid ${({ theme }) => theme.colorCancel}; | ||
| background-color: ${({ theme }) => theme.colorCancel}; | ||
| transition: ${({ theme }) => theme.btnTransition}; |
Collaborator
There was a problem hiding this comment.
you also can use a function with the theme here, if you need to return three styles in one func
${({ theme }) =>border: 1px solid ${theme.colorCancel};
background-color: ${theme.colorCancel};
transition: ${theme.btnTransition}};
Comment on lines
+14
to
+17
|
|
||
|
|
||
|
|
||
| return ( |
| <Wrapper> | ||
| <Root> | ||
| <BtnWrapper> | ||
| {location.pathname !== paths.newUser && <BackButton onClick={() => navigate(-1)} > back</BackButton>} |
Collaborator
There was a problem hiding this comment.
it's better to use goBack()
|
|
||
| &:hover { | ||
| transition: ${({ theme }) => theme.btnTransition}; | ||
| background-color: ${({ color, theme }) => color === 'cancel' ? theme.colorError : theme.colorAcceptLight}; |
Collaborator
There was a problem hiding this comment.
do you have a line characters limit? like 80?
| <> | ||
| { | ||
| isAuth ? ( | ||
| <Navigate to={paths.todos} /> |
| const navigate = useNavigate(); | ||
|
|
||
| if (isAuth) { | ||
| navigate('/todos'); |
Collaborator
There was a problem hiding this comment.
here you can use path variable too
| const docSnap = await getDocs(collection(db, 'todos')); | ||
| const data: ITodo[] = []; | ||
| docSnap.forEach(doc => { | ||
| // @ts-ignore |
Collaborator
There was a problem hiding this comment.
why you need to ignore smth here
Collaborator
There was a problem hiding this comment.
I think you can add types for getDocs or docSnap
| }); | ||
|
|
||
|
|
||
| // export const { } = todoSlice.actions; |
| ? await createUserWithEmailAndPassword(auth, uEmail, uPassword) | ||
| : await signInWithEmailAndPassword(auth, uEmail, uPassword); | ||
|
|
||
| // @ts-ignore |
Collaborator
There was a problem hiding this comment.
why? I think you can add some checker here (google TypeGuard)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.