fix ima in causal_conv1d_channellast_fwd_kernel#101
Open
POI-WX wants to merge 1 commit into
Open
Conversation
Author
|
@tridao could you please take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align seq_idx boundary condition handling with the bwd implementation to fix the out-of-bounds read access of seq_idx in the causal_conv1d_channellast_fwd_kernel function. Related issue: Problem with seq_idx #67
The aforementioned illegal memory access error is masked by the environment variable below during actual training. After unsetting it, we consistently reproduced the error with specific inputs and ultimately traced the issue to improper boundary condition handling.
export PYTORCH_CUDA_ALLOC_CONF=expandable_segments:Trueexport PYTORCH_ALLOC_CONF=expandable_segments:TruecudaMallocAsyncbackend or disable caching, and run it in conjunction with thecuda-memchecktool.replay_causal_conv1d_oob.py