Fixing Windows compile#58
Open
loscrossos wants to merge 1 commit into
Open
Conversation
Signed-off-by: LosCrossos <165311345+loscrossos@users.noreply.github.com>
Author
|
closed by error :D |
|
Please merge this PR |
Author
|
@tridao please accept this humble offering |
TimexPeachtree
approved these changes
Nov 17, 2025
TimexPeachtree
left a comment
TimexPeachtree
left a comment
There was a problem hiding this comment.
Awesome this has built perfectly on my Win 11 with VS 2022 and CUDA 12.8 with a Graphics card with CUDA Compute 8.9 Capability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR fixes the code with standard C++, so that it compiles under windows cleanly. the functionality is not changed at all as iwent extra careful: a standard c++ header is added with windows guardrails. one functon in each of the other 2 cu files merely refactored, again as to comply with the C++ standard. see #57 for a thorough description