Skip to content

Code quality #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UselessToucan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Code quality #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cb7a54
Remove redundant else if
UselessToucan Jan 19, 2021
dc1340a
Do not create empty DataTable objects
UselessToucan Jan 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions SPToCore/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ static async Task<int> Main(string[] args)

public static void SPToCoreScan() {

var dt_SpList = new DataTable();
var dt_SpParam = new DataTable();
var dt_SpResult = new DataTable();
DataTable dt_SpList;
DataTable dt_SpParam;
DataTable dt_SpResult;

Console.WriteLine($"{DateTime.Now.ToString("yyyy-MM-dd HH':'mm':'ss")} STEP 1 - GET STORED PROCEDURE LIST");

Expand Down Expand Up @@ -300,8 +300,6 @@ private static string SP_GetType(string type,bool isNullable)
return "int" + (isNullable ? "?" : "");
else if (type == "tinyint")
return "Byte" + (isNullable ? "?" : "");
else if (type == "bigint")
return "Int64" + (isNullable ? "?" : "");
else if (type.IndexOf("decimal") > -1)
return "decimal" + (isNullable ? "?" : "");
else if (type.IndexOf("nvarchar") > -1)
Expand Down Expand Up @@ -344,8 +342,6 @@ private static string SP_GetDbType(string type)
return "Int16";
else if (type == "tinyint")
return "Byte";
else if (type == "bigint")
return "Int64";
else if (type.IndexOf("decimal") > -1)
return "Decimal";
else if (type.IndexOf("nvarchar") > -1)
Expand Down