StaticLine - Implement Automatic Group Deployments

[mrschick]

When merged this pull request will:

• Implement Automatic Group Deployments:
  Implements ACE interactions to allow certain units within an aircraft to command the jump of a player/AI group that is hooked into the line. All units of the selected group(s) are then automatically automatically made to jump, spaced by 1s (realistic interval).
  The reasoning for this feature is that in Arma we lack freedom of movement within a vehicle, which makes it much more difficult than IRL to coordinate a sequential static line deployment with proper spacing.
  • Co-/Pilots and Jumpmasters (defined by object variable) can deploy any or all group(s) within the vehicle that have hooked in members;
  • Group leaders can deploy their own group;
  • The jump sequence of each group is automatically sorted, to ensure that units of the same "Team" (White/Red/Blue/Green/Yellow) land together;
  • CBA Settings to:
    • restrict the personnel that can command group deployments;
    • determine whether the leader of a group is deployed first or last (with his team);
• Fix Staticline - Locality issues in fnc_isRampOpen preventing MP jumps #78 ;
• Improve automatic backpack handling after landing;
• Fix broken image link in Helocast documentation;
• Optimize condition check in staticline_fnc_canJump;
• Fix undefined variable use in helocast_fnc_unloadBoatPFH;
• Remove Autosave from forced VSCode settings;

Important

• If the contribution affects the documentation, please include your changes in this pull request.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.
• If this PR adds support for a mod or (C)DLC, both README.md files have been updated.

Known Issues

• Unlike players, AI that is group-deployed won't be grouped according to their assigned team/color. That is unless the deployment is initiated by a player leader/jumpmaster in the same group.

[mrschick]

Fixed the jump interval being too short at slot speeds, leading to jumpers hitting each others chutes. It is now dynamically increased to up to 4 seconds by a linearConversion, when speed is below 100kph.

Ready for review.

[DartRuffian]

Overall looks good, might be worth extracting some of the repeated logic out to their own functions. Haven't had a chance to test yet, this was just me looking over the PR at work

[mrschick]

I implemented an automatic grouping by colors, to ensure that units of the same team/color aren't spread apart along the DZ. The logic is pretty clearly written and commented IMO.

Over this weekend I should be able to test this in MP with my clan, other than that I believe this PR is feature-complete.

[mrschick]

Turns out there are locality issues in MP, despite the relevant functions supposedly having Effect Global.

• Parachutes are correctly spawned if not worn, but remote units are not moved into them and end up having to open them manually.
  Should be easily fixed by running FUNC(jump) through a CBA_fnc_targetEvent.
• Grouping launches by assigned team/color is not respected when someone other than the group leader commands the deployment, most likely because assignedTeam for units of a different group doesn't work.
  This is more tricky to fix given the current code structure, my best idea would be letting each player run a PFH to keep their assignedTeam updated in a public object variable. The client commanding the deployment could then fetch the assignedTeam from the variable, to determine deployment order.
  However, this would not work for AI.

[mrschick]

This should fix the issues.
The only limitation is that it won't work on AI in a player group that were assigned a color, unless the player in that group triggers the group's deployment. But I don't think that's too bad.

[mrschick]

Tested this today with a few lads, locality issues were fixed as expected.

I've noticed some issues with the jump and group deployment conditions on a DS though, on some aircraft (RHS CH-47, C-130) it just wouldn't return true, even though the ramp was in the correct position.
Not sure what the cause is, as it seemed to also present with the latest public version, but might be related to the conditions' refactor in this PR. Will investigate this week.

[mrschick]

I've noticed some issues with the jump and group deployment conditions on a DS though, on some aircraft (RHS CH-47, C-130) it just wouldn't return true, even though the ramp was in the correct position.

@DartRuffian Mentioned issue has been identified as #78. I could fix it in this PR in a distinct commit, depending on which solution you prefer.

[DartRuffian]

I'd just round to the tenths place like you had suggested, but probably good to make a ticket about animationSourcePhase as well

[DartRuffian]

Should be good after these

[DartRuffian]

Just to make sure, is this PR complete or do you have other fixes/things you want to add?

[mrschick]

It's complete.

[mrschick]

Are you going to update the mod soon? I'm eager to do group deployment with the boys 😁

[DartRuffian]

That's the plan, just been busy with stuff recently. I should have time tomorrow