Feature/boundary conditions - #17
Merged
Merged
Conversation
implements 'createBoundaries' and fix it's name to 'createBoundaryConditions', also adds a configuration entry and patch configuration test accordingly
Adds wall as a default fall back option, and raise NotImplementedError if a namespace doesn't have an associated implementation. Also adds docs and comments
implements tests that handle grouping verification and specific errors
Adds group_number only in raw format and don't keep it in geometry, group_number is conserved using an output parameter for boundary to raw boundary association This association allows to keep track of not only the group number but also ghost cell bathymetry!
implements boundary condition creation and ghost cell bathymetry in the main runner, correct some files to make this possible
implements both discharg1 and ratcurve using abstract dynamic boundary condition which is all boundary condition that uses a float function of time as input in a file. Also patch some errors in other files for the implementation to work
files that have fortran comments (beginning with '!') were not supported, now they are properly ignored in file reading. And a test file was missing, it has been added
implements wall boundary condition and tests, these tests are generated by AI and can be the source of misstrust, though it is on a very simple class so I think it's tolerable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully implements a subset of boundary conditions