ENH: add backward run - #541
Merged
Merged
Conversation
maximejay
requested changes
Sep 1, 2026
maximejay
left a comment
maximejay
left a comment
Collaborator
There was a problem hiding this comment.
Super !
J'ai parcouru le code simplement. Juste détaillé un peu plus la doc de la fonction backward_run pour y comprendre un peu quelque chose (voir ma suggestion en commentaire).
Pour les résultats, il sont cohérent avec ceux que j'avais avec ma PR. Donc ca semble tout bon :)
A++
Merci
Collaborator
|
Super |
maximejay
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.