Open
Conversation
clearfeld
requested changes
Apr 6, 2024
| use chrono::{Datelike, Utc}; | ||
|
|
||
| #[wasm_bindgen] | ||
| pub fn get_cc_number() -> String { |
Contributor
There was a problem hiding this comment.
Change the function names to the format of credit_card_{number} to match the rest of the library function names.
Collaborator
Author
There was a problem hiding this comment.
Changed function names, please check.
clearfeld
requested changes
Apr 7, 2024
| #[wasm_bindgen] | ||
| pub fn get_cc_number() -> String { | ||
| let cardnum = get_cc_number_and_issuer(); | ||
| pub fn get_credit_card_number() -> String { |
Contributor
There was a problem hiding this comment.
Get rid of the get at the start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.