Use c.git.repository_url and c.git.commit_sha if it is defined instead of env vars#487
Draft
Use c.git.repository_url and c.git.commit_sha if it is defined instead of env vars#487
Conversation
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 8224da4 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR replace the direct access to DD_GIT_REPOSITORY_URL and DD_GIT_COMMIT_SHA to access to the config DSL. There is a fallback mechanism if the option is not defined on dd-trace-rb (for older versions).
Motivation
We're trying to move as much env vars as possible to the config DSL, so that they can be configured programmatically, but also through stable config. These two configs are common to both dd-trace-rb and datadog-ci-rb.
Additional Notes
Depends on DataDog/dd-trace-rb#5559
How to test the change?