Skip to content

Use c.git.repository_url and c.git.commit_sha if it is defined instead of env vars#487

Draft
vpellan wants to merge 1 commit intomainfrom
vpellan/access-git-repo-and-commit-sha-config
Draft

Use c.git.repository_url and c.git.commit_sha if it is defined instead of env vars#487
vpellan wants to merge 1 commit intomainfrom
vpellan/access-git-repo-and-commit-sha-config

Conversation

@vpellan
Copy link
Copy Markdown

@vpellan vpellan commented Apr 3, 2026

What does this PR do?

This PR replace the direct access to DD_GIT_REPOSITORY_URL and DD_GIT_COMMIT_SHA to access to the config DSL. There is a fallback mechanism if the option is not defined on dd-trace-rb (for older versions).

Motivation

We're trying to move as much env vars as possible to the config DSL, so that they can be configured programmatically, but also through stable config. These two configs are common to both dd-trace-rb and datadog-ci-rb.

Additional Notes

Depends on DataDog/dd-trace-rb#5559

How to test the change?

@datadog-prod-us1-5
Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 78.38%
Overall Coverage: 97.04% (-0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8224da4 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant