Repository navigation
fix: refresh den-54 SQL logic expectations - #173
Merged
Merged
Conversation
mitchsw
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None. This fixes stale expectations introduced by backports already present on
den-54.Rationale for this change
The
den-54Rust workflow is failing because the metrics-cardinality backport added thedatafusion.execution.metrics_cardinalitysetting and causes the compact Parquet metricpage_index_pages_skipped_by_fully_matchedto be emitted at zero, but the corresponding SQL logic expectations were not refreshed.What changes are included in this PR?
Refresh the affected expectations in
information_schema.sltandpush_down_filter_parquet.slt. No runtime code changes are included.Are these changes tested?
cargo +1.95.0 fmt --all -- --checkcargo +1.95.0 clippy --all-targets --all-features -- -D warningscargo +1.95.0 test --profile=ci --test sqllogictests -- information_schema.sltcargo +1.95.0 test --profile=ci --test sqllogictests -- push_down_filter_parquet.sltAre there any user-facing changes?
No.