Open
Conversation
brettlangdon
reviewed
Aug 9, 2019
Member
brettlangdon
left a comment
brettlangdon
left a comment
There was a problem hiding this comment.
This looks good to me, but lets hold until we can confirm why we are seeing status code of 0 and if that is actually an issue or not.
Contributor
Author
|
Assuming we confirm this, should the span be tagged as an error? |
|
@cgilmour it depends on the meaning of the field. If the fact it is not reported is because of an error (and so Envoy bails out before assigning an HTTP status code) then yes. If it's really generic and it happens also for legit reasons, it should not be considered an error. |
Contributor
|
Happy 2021. Is this feature needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under some circumstances, envoy adds the
http.status_codetag with a value that isn't permitted by Datadog.Although invalid values are detected in newer versions of the agent, and corrected by removing that tag from the span, it's better if it doesn't occur at all.
This PR ignores the
http.status_codetag if the value is"0".