Skip to content

Fix SnapshotSlicerTests verify prefix - #9009

Merged
NachoEchevarria merged 1 commit into
masterfrom
nacho/FixFlakyRetry
Aug 18, 2026
Merged

Fix SnapshotSlicerTests verify prefix#9009
NachoEchevarria merged 1 commit into
masterfrom
nacho/FixFlakyRetry

Conversation

@NachoEchevarria

@NachoEchevarria NachoEchevarria commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Summary of changes

Allow the three flaky SnapshotSlicerTests snapshot tests to reuse their Verify prefix during retries.

Reason for change

When one of these tests hits its known JSON flake, the retry runs in the same process. Verify then rejects the second attempt because the snapshot prefix was already registered, causing the retry to fail for an unrelated reason.

Error:

2026-08-06T15:32:18.619631Z 01O 15:32:18 [ERR] [xUnit.net 00:00:43.86]     Datadog.Trace.Tests.Debugger.SnapshotSlicerTests.SnapshotBiggerThanMaxSize_TwoLevel_OneSliced [FAIL]
2026-08-06T15:32:19.648960Z 01O 15:32:19 [DBG]   Failed Datadog.Trace.Tests.Debugger.SnapshotSlicerTests.SnapshotBiggerThanMaxSize_TwoLevel_OneSliced [12 ms]
2026-08-06T15:32:19.654330Z 01O 15:32:19 [DBG]   Error Message:
2026-08-06T15:32:19.654900Z 01O 15:32:19 [DBG]    System.Exception : The prefix has already been used: c:\mnt\tracer\test\Datadog.Trace.Tests\Debugger\SnapshotSlicerTests.SnapshotBiggerThanMaxSize_TwoLevel_OneSliced.
2026-08-06T15:32:19.654900Z 01O 15:32:19 [DBG] This is mostly caused by a conflicting combination of `VerifierSettings.DerivePathInfo()`, `UseMethodName.UseDirectory()`, `UseMethodName.UseTypeName()`, and `UseMethodName.UseMethodName()`.
2026-08-06T15:32:19.655350Z 01O 15:32:19 [DBG] If that's not the case, and having multiple identical prefixes is acceptable, then call `VerifierSettings.DisableRequireUniquePrefix()` to disable this uniqueness validation.
2026-08-06T15:32:19.655350Z 01O 15:32:19 [DBG]   Stack Trace:
2026-08-06T15:32:19.655350Z 01O 15:32:19 [DBG]      at PrefixUnique.CheckPrefixIsUnique(String prefix) in /_/src/Verify/Naming/PrefixUnique.cs:line 11
2026-08-06T15:32:19.655350Z 01O 15:32:19 [DBG]    at InnerVerifier.ValidatePrefix(VerifySettings settings, String filePathPrefix) in /_/src/Verify/Verifier/InnerVerifier.cs:line 56
2026-08-06T15:32:19.655350Z 01O 15:32:19 [DBG]    at InnerVerifier..ctor(String sourceFile, VerifySettings settings, GetFileConvention fileConvention) in /_/src/Verify/Verifier/InnerVerifier.cs:line 31
2026-08-06T15:32:19.655350Z 01O 15:32:19 [DBG]    at VerifyXunit.Verifier.GetVerifier(VerifySettings settings, String sourceFile) in /_/src/Verify.Xunit/Verifier.cs:line 14
2026-08-06T15:32:19.655890Z 01O 15:32:19 [DBG]    at VerifyXunit.Verifier.<>c__DisplayClass1_0.<<Verify>b__0>d.MoveNext() in /_/src/Verify.Xunit/Verifier.cs:line 31
2026-08-06T15:32:19.655890Z 01O 15:32:19 [DBG] --- End of stack trace from previous location ---
2026-08-06T15:32:19.655890Z 01O 15:32:19 [DBG]    at Datadog.Trace.Tests.Debugger.SnapshotSlicerTests.SnapshotBiggerThanMaxSize_TwoLevel_OneSliced() in c:\mnt\tracer\test\Datadog.Trace.Tests\Debugger\SnapshotSlicerTests.cs:line 80
2026-08-06T15:32:19.656320Z 01O 15:32:19 [DBG] --- End of stack trace from previous location ---

Implementation details

Pass VerifySettings with DisableRequireUniquePrefix() to the tests already marked [Flaky].

Test coverage

Built Datadog.Trace.Tests and ran SnapshotBiggerThanMaxSize_TwoLevel_OneSliced locally.

Other details

None.

@github-actions github-actions Bot added the area:tests unit tests, integration tests label Aug 7, 2026
@pr-commenter

pr-commenter Bot commented Aug 7, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-08-07 10:00:03

Comparing candidate commit e58816a in PR branch nacho/FixFlakyRetry with baseline commit f508c00 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 2 performance regressions! Performance is the same for 70 metrics, 0 unstable metrics, 67 known flaky benchmarks, 59 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net472

  • 🟥 throughput [-21881.123op/s; -17925.893op/s] or [-6.163%; -5.049%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472

  • 🟥 throughput [-6384.888op/s; -5685.422op/s] or [-7.289%; -6.490%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-10490.166op/s; -9109.637op/s] or [-12.438%; -10.801%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 throughput [-11972.858op/s; -9210.052op/s] or [-12.174%; -9.365%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+310.876ms; +318.418ms] or [+154.268%; +158.010%]
  • 🟥 throughput [-43.216op/s; -39.354op/s] or [-7.775%; -7.080%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+379.449ms; +381.961ms] or [+299.788%; +301.773%]
  • 🟩 throughput [+91.083op/s; +95.342op/s] or [+12.009%; +12.570%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+397.842ms; +399.217ms] or [+352.075%; +353.292%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+4.693KB; +4.694KB] or [+98.806%; +98.821%]
  • 🟥 throughput [-60505.794op/s; -60136.609op/s] or [-47.077%; -46.789%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.816KB; +3.816KB] or [+80.699%; +80.711%]
  • 🟩 execution_time [-16.265ms; -12.090ms] or [-7.596%; -5.647%]
  • 🟥 throughput [-59259.882op/s; -56499.929op/s] or [-43.256%; -41.242%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+4.544KB; +4.544KB] or [+98.261%; +98.274%]
  • 🟥 throughput [-49053.220op/s; -46805.356op/s] or [-44.350%; -42.317%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.315KB; +1.315KB] or [+106.388%; +106.404%]
  • 🟥 throughput [-273476.769op/s; -269571.126op/s] or [-27.923%; -27.525%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+479 bytes; +480 bytes] or [+39.212%; +39.221%]
  • 🟩 execution_time [-26.180ms; -21.320ms] or [-11.675%; -9.508%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.280KB; +1.280KB] or [+105.947%; +105.963%]
  • 🟥 throughput [-160100.619op/s; -143969.653op/s] or [-23.003%; -20.686%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472

  • 🟥 allocated_mem [+3.378KB; +3.378KB] or [+89.003%; +89.017%]
  • 🟥 throughput [-72768.590op/s; -72011.303op/s] or [-48.972%; -48.463%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.336KB; +3.336KB] or [+88.150%; +88.161%]
  • 🟥 throughput [-72970.960op/s; -70092.456op/s] or [-46.430%; -44.599%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+3.264KB; +3.264KB] or [+88.493%; +88.506%]
  • 🟥 throughput [-55506.954op/s; -52894.607op/s] or [-44.219%; -42.137%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+318036.897op/s; +361189.431op/s] or [+10.605%; +12.044%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-19.110ms; -14.780ms] or [-8.809%; -6.813%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟩 allocated_mem [-13.759KB; -13.757KB] or [-42.326%; -42.318%]
  • 🟥 execution_time [+300.231ms; +300.967ms] or [+150.015%; +150.383%]
  • 🟩 throughput [+1022.851op/s; +1038.180op/s] or [+11.297%; +11.467%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟩 allocated_mem [-13.722KB; -13.718KB] or [-42.341%; -42.329%]
  • 🟥 execution_time [+299.506ms; +302.605ms] or [+151.042%; +152.604%]
  • 🟩 throughput [+2354.270op/s; +2564.496op/s] or [+18.007%; +19.615%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟩 allocated_mem [-13.722KB; -13.718KB] or [-42.341%; -42.329%]
  • 🟥 execution_time [+300.098ms; +302.472ms] or [+151.166%; +152.362%]
  • 🟩 throughput [+1769.651op/s; +1895.223op/s] or [+17.085%; +18.297%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+297.444ms; +298.428ms] or [+146.093%; +146.576%]
  • 🟩 throughput [+581.184op/s; +603.065op/s] or [+15.407%; +15.987%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+295.437ms; +297.812ms] or [+144.428%; +145.589%]
  • 🟩 throughput [+2668.270op/s; +2720.482op/s] or [+38.765%; +39.524%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+301.237ms; +302.569ms] or [+150.558%; +151.224%]
  • 🟩 throughput [+1384.280op/s; +1403.850op/s] or [+27.477%; +27.865%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472

  • 🟩 execution_time [-143.456µs; -139.440µs] or [-29.453%; -28.629%]
  • 🟩 throughput [+827.649op/s; +854.034op/s] or [+40.310%; +41.595%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0

  • 🟩 execution_time [-138.511µs; -111.871µs] or [-31.768%; -25.658%]
  • 🟩 throughput [+856.835op/s; +978.664op/s] or [+37.252%; +42.548%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

  • 🟩 execution_time [-143.155µs; -121.197µs] or [-30.671%; -25.967%]
  • 🟩 throughput [+781.969op/s; +864.029op/s] or [+36.097%; +39.885%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472

  • 🟩 execution_time [-125.660µs; -120.700µs] or [-33.927%; -32.588%]
  • 🟩 throughput [+1316.501op/s; +1379.403op/s] or [+48.757%; +51.087%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟩 execution_time [-105.020µs; -81.458µs] or [-33.528%; -26.006%]
  • 🟩 throughput [+1238.164op/s; +1438.423op/s] or [+38.597%; +44.840%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1

  • 🟩 execution_time [-137.795µs; -115.373µs] or [-37.695%; -31.561%]
  • 🟩 throughput [+1330.041op/s; +1468.530op/s] or [+47.730%; +52.700%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.763ms; +300.477ms] or [+149.612%; +149.969%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+269.109ms; +344.154ms] or [+292.398%; +373.938%]
  • 🟩 throughput [+711.583op/s; +926.304op/s] or [+5.847%; +7.612%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • 🟥 execution_time [+364.419ms; +369.838ms] or [+276.700%; +280.814%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 allocated_mem [+2.824KB; +2.829KB] or [+5.017%; +5.027%]
  • unstable execution_time [+308.182ms; +341.913ms] or [+141.699%; +157.208%]
  • 🟥 throughput [-490.638op/s; -454.468op/s] or [-44.457%; -41.179%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+205.712ms; +338.967ms] or [+87.666%; +144.453%]
  • 🟥 throughput [-669.989op/s; -586.523op/s] or [-44.688%; -39.121%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+338.788ms; +347.519ms] or [+202.634%; +207.856%]
  • 🟥 throughput [-387.453op/s; -352.126op/s] or [-26.978%; -24.518%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0

  • 🟩 throughput [+48.950op/s; +91.519op/s] or [+5.278%; +9.868%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-191.941µs; -124.484µs] or [-9.723%; -6.306%]
  • 🟩 throughput [+37.213op/s; +55.328op/s] or [+7.346%; +10.922%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+302.726ms; +304.561ms] or [+152.447%; +153.371%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+301.436ms; +303.353ms] or [+151.050%; +152.011%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+299.825ms; +303.070ms] or [+150.619%; +152.250%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+302.785ms; +304.306ms] or [+152.049%; +152.813%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+297.747ms; +300.511ms] or [+147.223%; +148.589%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+303.772ms; +307.423ms] or [+153.965%; +155.816%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+302.801ms; +304.983ms] or [+151.979%; +153.074%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+300.515ms; +302.757ms] or [+149.779%; +150.897%]
  • 🟩 throughput [+36762.922op/s; +42778.571op/s] or [+7.300%; +8.494%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+298.834ms; +301.934ms] or [+148.667%; +150.210%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟩 execution_time [-16.452ms; -12.802ms] or [-7.650%; -5.953%]
  • 🟩 throughput [+20872.649op/s; +27447.845op/s] or [+5.726%; +7.530%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+18.275µs; +62.487µs] or [+4.514%; +15.435%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-20.207KB; -20.185KB] or [-7.371%; -7.363%]
  • unstable execution_time [-50.857µs; +3.448µs] or [-10.052%; +0.681%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • unstable execution_time [-55.130µs; +7.444µs] or [-9.554%; +1.290%]
  • unstable throughput [-8.360op/s; +168.637op/s] or [-0.478%; +9.634%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • 🟥 execution_time [+5.971µs; +10.128µs] or [+14.113%; +23.939%]
  • 🟥 throughput [-4678.651op/s; -2890.210op/s] or [-19.696%; -12.167%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-13.991µs; -5.687µs] or [-21.706%; -8.824%]
  • unstable throughput [+1489.645op/s; +3332.356op/s] or [+9.139%; +20.445%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+301.825ms; +303.079ms] or [+152.559%; +153.193%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+301.259ms; +303.535ms] or [+153.340%; +154.498%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+299.259ms; +301.532ms] or [+149.816%; +150.954%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+297.437ms; +299.465ms] or [+148.246%; +149.256%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+301.892ms; +304.039ms] or [+151.596%; +152.674%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+303.294ms; +305.694ms] or [+153.811%; +155.028%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+299.328ms; +300.227ms] or [+149.306%; +149.755%]
  • 🟩 throughput [+65787929.423op/s; +66177467.279op/s] or [+47.911%; +48.195%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+424.445ms; +427.712ms] or [+527.873%; +531.936%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+298.762ms; +299.832ms] or [+149.015%; +149.550%]
  • 🟩 throughput [+13527059.060op/s; +17207033.507op/s] or [+5.992%; +7.622%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 throughput [+80594.286op/s; +93754.010op/s] or [+7.525%; +8.754%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟩 throughput [+46795.312op/s; +66716.240op/s] or [+5.416%; +7.722%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • 🟩 throughput [+91929.167op/s; +121210.904op/s] or [+7.115%; +9.382%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 throughput [+73696.546op/s; +81609.977op/s] or [+7.319%; +8.105%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+45814.278op/s; +51765.559op/s] or [+8.319%; +9.400%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 throughput [+22489.092op/s; +32489.673op/s] or [+5.034%; +7.272%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟩 throughput [+60363.513op/s; +80435.206op/s] or [+6.744%; +8.987%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (9009) and master.

✅ No regressions detected

📄 View the full report (charts + all metrics) →

@NachoEchevarria

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: e58816a284

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@NachoEchevarria NachoEchevarria changed the title Update SnapshotSlicerTests.cs Fix SnapshotSlicerTests verify prefix Aug 18, 2026
@NachoEchevarria
NachoEchevarria marked this pull request as ready for review August 18, 2026 10:18
@NachoEchevarria
NachoEchevarria requested a review from a team as a code owner August 18, 2026 10:18

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wow, I didn't know that was a thing 😬 That's something we'll have to remember any time we have [Flaky] on a test then 😬

@dudikeleti dudikeleti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@NachoEchevarria
NachoEchevarria merged commit 34dfabe into master Aug 18, 2026
142 of 143 checks passed
@NachoEchevarria
NachoEchevarria deleted the nacho/FixFlakyRetry branch August 18, 2026 11:50
@github-actions github-actions Bot added this to the vNext-v3 milestone Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tests unit tests, integration tests type:flake-fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants