Skip to content

Add LockSupport TaskBlock profiling instrumentation#11545

Draft
kaahos wants to merge 14 commits into
masterfrom
paul.fournillon/wallclock-locksupport-taskblock
Draft

Add LockSupport TaskBlock profiling instrumentation#11545
kaahos wants to merge 14 commits into
masterfrom
paul.fournillon/wallclock-locksupport-taskblock

Conversation

@kaahos

@kaahos kaahos commented Jun 3, 2026

Copy link
Copy Markdown

What Does This Do

Add TaskBlock profiling instrumentation for LockSupport.park/unpark, including blocker and unblocking span attribution where available.

Motivation

LockSupport.park is widely used by executors, queues, schedulers, and virtual-thread internals. Capturing these park intervals as TaskBlock events makes parked time attributable to spans and easier to separate from active execution in wall-clock profiles.

Additional Notes

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@datadog-official

datadog-official Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 3.88%
Overall Coverage: 54.92% (-2.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b795bf9 | Docs | Datadog PR Page | Give us feedback!

@kaahos kaahos force-pushed the paul.fournillon/wallclock-locksupport-taskblock branch from 804e4ef to c3fca82 Compare June 3, 2026 12:20
@kaahos kaahos force-pushed the paul.fournillon/wallclock-locksupport-taskblock branch from c3fca82 to db17e59 Compare June 5, 2026 08:47
@kaahos kaahos force-pushed the paul.fournillon/wallclock-locksupport-taskblock branch from db17e59 to b5ead17 Compare June 5, 2026 09:32
@kaahos kaahos force-pushed the paul.fournillon/wallclock-locksupport-taskblock branch from b5ead17 to 235547a Compare June 5, 2026 13:18
Comment thread dd-trace-api/src/main/java/datadog/trace/api/config/ProfilingConfig.java Outdated
Comment thread metadata/supported-configurations.json Outdated
@kaahos kaahos force-pushed the paul.fournillon/wallclock-locksupport-taskblock branch from 235547a to 84fded4 Compare June 12, 2026 13:25
@kaahos kaahos force-pushed the paul.fournillon/wallclock-locksupport-taskblock branch from a20d06d to 71c8070 Compare July 6, 2026 09:54
@dd-octo-sts

dd-octo-sts Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🔴 Java Benchmark SLOs — Performance SLO breach detected

Suite Status
Startup 🔴 breach

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.82 s 14.63 s [+0.5%; +2.0%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.63 s 13.72 s [-1.5%; +0.1%] (no difference)
startup:petclinic:appsec:Agent 16.88 s 16.83 s [-0.5%; +1.2%] (no difference)
startup:petclinic:iast:Agent 16.33 s 16.97 s [-8.0%; +0.4%] (no difference)
startup:petclinic:profiling:Agent 16.76 s 16.93 s [-1.9%; -0.1%] (maybe better)
startup:petclinic:sca:Agent 16.91 s 16.53 s [+1.1%; +3.5%] (significantly worse)
startup:petclinic:tracing:Agent 15.98 s 16.07 s [-1.5%; +0.4%] (no difference)

Commit: 71c80707 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@kaahos kaahos force-pushed the paul.fournillon/wallclock-locksupport-taskblock branch from 71c8070 to b795bf9 Compare July 6, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants