Skip to content

Update AggregateEntry to Split OK/Error Latencies #11719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhlidd wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update AggregateEntry to Split OK/Error Latencies #11719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions dd-trace-core/src/main/java/datadog/trace/common/metrics/AggregateEntry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ final class AggregateEntry extends Hashtable.Entry {
private int errorCount;
private int hitCount;
private int topLevelCount;
private long duration;
private long okDuration;
private long errorDuration;

/**
* Field-bearing constructor. Package-private so {@link AggregateEntryTestUtils} can build
Expand Down Expand Up @@ -155,11 +156,12 @@ AggregateEntry recordOneDuration(long tagAndDuration) {
if ((tagAndDuration & ERROR_TAG) == ERROR_TAG) {
tagAndDuration ^= ERROR_TAG;
errorLatenciesForWrite().accept(tagAndDuration);
errorDuration += tagAndDuration;
++errorCount;
} else {
okLatencies.accept(tagAndDuration);
okDuration += tagAndDuration;
}
duration += tagAndDuration;
return this;
}

Expand All @@ -176,7 +178,15 @@ int getTopLevelCount() {
}

long getDuration() {
return duration;
return okDuration + errorDuration;
}

long getOkDuration() {
return okDuration;
}

long getErrorDuration() {
return errorDuration;
}

Histogram getOkLatencies() {
Expand Down Expand Up @@ -214,7 +224,8 @@ void clear() {
this.errorCount = 0;
this.hitCount = 0;
this.topLevelCount = 0;
this.duration = 0;
this.okDuration = 0;
this.errorDuration = 0;
this.okLatencies.clear();
// errorLatencies stays null on entries that never errored. Only clear if it was allocated.
if (this.errorLatencies != null) {
Expand Down