Skip to content

Enable and fix test coverage for SCA types in internal API#11774

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
bdu/sca-internal-api-coverage-tests
Jun 30, 2026
Merged

Enable and fix test coverage for SCA types in internal API#11774
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
bdu/sca-internal-api-coverage-tests

Conversation

@bric3

@bric3 bric3 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

This pull request adds coverage tests for proxy span metadata, ARN computation, and SCV dependency handling. It also fixes and ensures coverage is enabled in the build configuration when requested or when testJvm matches the daemon JDK.

Motivation

Additional Notes

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@bric3 bric3 requested review from a team as code owners June 29, 2026 13:50
@dd-octo-sts

dd-octo-sts Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@bric3 bric3 added type: bug Bug report and fix tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jun 29, 2026
@datadog-datadog-prod-us1-2

This comment has been minimized.

@bric3 bric3 force-pushed the bdu/sca-internal-api-coverage-tests branch from f0aab6e to 57cc8f6 Compare June 29, 2026 14:04
@dd-octo-sts

dd-octo-sts Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.98 s 13.91 s [-0.2%; +1.2%] (no difference)
startup:insecure-bank:tracing:Agent 12.90 s 12.97 s [-1.2%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 16.92 s 16.63 s [+0.8%; +2.6%] (maybe worse)
startup:petclinic:iast:Agent 16.83 s 16.98 s [-1.7%; -0.1%] (maybe better)
startup:petclinic:profiling:Agent 16.78 s 16.86 s [-1.5%; +0.5%] (no difference)
startup:petclinic:sca:Agent 16.81 s 16.76 s [-0.6%; +1.2%] (no difference)
startup:petclinic:tracing:Agent 16.09 s 16.14 s [-1.3%; +0.7%] (no difference)

Commit: ca5c9f9b · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3 bric3 changed the title Enable and fix test coverage in build configuration Enable and fix test coverage for SCA types in internal API Jun 29, 2026
@bric3 bric3 requested review from claponcet and jandro996 June 29, 2026 15:41
@bric3

bric3 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jun 29, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-29 15:57:36 UTC ℹ️ Start processing command /merge


2026-06-29 15:57:47 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-06-29 20:02:09 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@jandro996 jandro996 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions on the new tests.

Comment thread internal-api/src/test/java/datadog/trace/api/gateway/InferredProxySpanTests.java Outdated
Comment thread internal-api/src/test/java/datadog/trace/api/gateway/InferredProxySpanTests.java Outdated
Comment thread internal-api/src/test/java/datadog/trace/api/gateway/InferredProxySpanTests.java Outdated

@jandro996 jandro996 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just some minor comments (not need to be done)
Thanks a lot for your help

@bric3 bric3 requested a review from a team as a code owner June 30, 2026 09:10
@bric3 bric3 enabled auto-merge June 30, 2026 09:11
@bric3 bric3 force-pushed the bdu/sca-internal-api-coverage-tests branch from 818de53 to ca5c9f9 Compare June 30, 2026 09:19
@bric3 bric3 added this pull request to the merge queue Jun 30, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jun 30, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-30 10:11:01 UTC ℹ️ Start processing command /merge


2026-06-30 10:11:06 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-06-30 11:10:03 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 30, 2026
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit e4274f3 into master Jun 30, 2026
583 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the bdu/sca-internal-api-coverage-tests branch June 30, 2026 11:10
@github-actions github-actions Bot added this to the 1.64.0 milestone Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: bug Bug report and fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants