Add 128 bit TID parsing tests#11802
Conversation
PerfectSlayer
added
the
tag: no release notes
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f754267a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| @TableTest({ | ||
| "default bounds | 0123456789abcdeffedcba9876543210 | 0 | 32 | true | 0123456789abcdeffedcba9876543210", |
There was a problem hiding this comment.
This table starts with a data row instead of the required header row; the project TableTest docs state that the first row is the header and that a scenario column is consumed by the runner. As written, default bounds is interpreted as a column name, so the actual data rows still include the scenario-name column while the test method only accepts five parameters, causing this parameterized test to be mis-bound/fail when DDTraceIdTest runs. Add a header such as scenario | hexId | start | length | lowerCaseOnly | expectedHexId before the cases.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I think it's right the first row might be skipped.
EDIT: Oh I see you already answered first.
|
For reference, this test supersedes the test of |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
#11801) chore(api): Exclude AIGuard and LLMObs class from coverage test(api): Add tests for 128-bit trace IDs and protocol versions test(api): Remove 128-bit trace IDs test, better equivalent in #11802 Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
3 participants
What Does This Do
Add missing test coverage
Motivation
Additional Notes
Reworked groovy migrated code a bit too.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]