Skip to content

Introduces the api-management inferred proxy spans to Azure#11804

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
TopherC-dd/azure-apim-proxy-imp
Jun 30, 2026
Merged

Introduces the api-management inferred proxy spans to Azure#11804
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
TopherC-dd/azure-apim-proxy-imp

Conversation

@TophrC-dd

Copy link
Copy Markdown
Contributor

What Does This Do

This PR introduces the api-management inferred proxy spans to Azure. It leverages the existing inferred proxy span component. This works by looking for a magic value in one of the received headers.
APMSVLS-539
image

In the headers we also add metadata for Http Method, Path, Region and origin domain name.

Motivation

My motivation for this is have the java-tracer have feature parity with Node, Python and .Net that already support this inferred span.

Additional Notes

For testing I have setup a multi service distributed trace with another service upstream from the Api Management span.

image

@TophrC-dd TophrC-dd marked this pull request as ready for review June 30, 2026 12:53
@TophrC-dd TophrC-dd requested review from a team as code owners June 30, 2026 12:53
@TophrC-dd TophrC-dd requested review from claponcet and jandro996 June 30, 2026 12:53
@dd-octo-sts

dd-octo-sts Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@TophrC-dd TophrC-dd added comp: core Tracer core type: enhancement Enhancements and improvements inst: azure-functions Azure Functions instrumentation labels Jun 30, 2026
@TophrC-dd TophrC-dd changed the title Topher c dd/azure apim proxy imp feat(apim): Add implementation for azure apim Jun 30, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.98 s 13.88 s [-0.0%; +1.4%] (no difference)
startup:insecure-bank:tracing:Agent 12.92 s 12.96 s [-1.2%; +0.5%] (no difference)
startup:petclinic:appsec:Agent 16.93 s 16.16 s [+0.3%; +9.2%] (maybe worse)
startup:petclinic:iast:Agent 16.85 s 16.98 s [-1.6%; +0.1%] (no difference)
startup:petclinic:profiling:Agent 16.87 s 16.95 s [-1.5%; +0.6%] (no difference)
startup:petclinic:sca:Agent 16.93 s 16.73 s [+0.2%; +2.1%] (maybe worse)
startup:petclinic:tracing:Agent 16.04 s 16.13 s [-1.6%; +0.5%] (no difference)

Commit: f59fa8b9 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@PerfectSlayer PerfectSlayer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

🎯 suggestion: ‏I would recommend renaming the PR with a title that would make sense for the customers in the change log. So maybe:

Introduces the api-management inferred proxy spans to Azure

(no feat() prefix needed)

@TophrC-dd TophrC-dd changed the title feat(apim): Add implementation for azure apim Introduces the api-management inferred proxy spans to Azure Jun 30, 2026

@jcstorms1 jcstorms1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@TophrC-dd TophrC-dd added this pull request to the merge queue Jun 30, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jun 30, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-30 18:24:31 UTC ℹ️ Start processing command /merge


2026-06-30 18:24:36 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-06-30 19:55:05 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 30, 2026
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit dcbee66 into master Jun 30, 2026
598 of 601 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the TopherC-dd/azure-apim-proxy-imp branch June 30, 2026 19:55
@github-actions github-actions Bot added this to the 1.64.0 milestone Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core inst: azure-functions Azure Functions instrumentation type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants