-
Notifications
You must be signed in to change notification settings - Fork 167
refactor(profiling): use libdd-profiling's ThinStr #3631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Benchmarks [ profiler ]Benchmark execution time: 2026-02-10 17:34:39 Comparing candidate commit 30e16e1 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 26 metrics, 8 unstable metrics. scenario:walk_stack/50
scenario:walk_stack/99
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3631 +/- ##
==========================================
+ Coverage 62.20% 62.21% +0.01%
==========================================
Files 141 141
Lines 13387 13387
Branches 1753 1753
==========================================
+ Hits 8327 8329 +2
+ Misses 4263 4260 -3
- Partials 797 798 +1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Description
This replaces the
ThinStrdefined in this module with the one that is inlibdd-profilinginstead. Note that the one inlibdd-profilingwas a copy + refactor of this one, which is why the migration is so easy.Reviewer checklist