Skip to content

Conversation

@Leiyks
Copy link
Contributor

@Leiyks Leiyks commented Feb 11, 2026

Description

Resolves flakiness in multiple test suites:

Laravel Octane: Fixed race condition where test callbacks matched spans before controller execution completed. Added resource name validation to ensure full trace capture.

Git metadata cache: Added cache invalidation for long-lived worker processes when git directories become invalid or commits change. Improved nginx readiness check with settle time to prevent 502 errors.

SQL Server integration: Switched from SQL Server 2022 to 2019 image to avoid kernel 6.7+ compatibility issues causing SIGABRT crashes on container startup.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 11, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 1028 Tests failed

    ❄️ Known flaky: Endpoints are sent() from com.datadog.appsec.php.integration.Laravel8xTests (Fix with Cursor)

    ❄️ Known flaky: telemetry data is received() from com.datadog.appsec.php.integration.TelemetryTests (Fix with Cursor)

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 17c6cae | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.12%. Comparing base (de9c414) to head (17c6cae).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3639      +/-   ##
==========================================
- Coverage   62.21%   62.12%   -0.09%     
==========================================
  Files         141      141              
  Lines       13387    13387              
  Branches     1753     1753              
==========================================
- Hits         8329     8317      -12     
- Misses       4260     4270      +10     
- Partials      798      800       +2     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de9c414...17c6cae. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Feb 11, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-02-12 01:49:44

Comparing candidate commit 92979ce in PR branch leiyks/fix-laravel-octnae-tests with baseline commit c14dafe in branch master.

Found 1 performance improvements and 8 performance regressions! Performance is the same for 182 metrics, 3 unstable metrics.

scenario:ContextPropagationBench/benchInject64Bit-opcache

  • 🟩 execution_time [-692.400ns; -293.600ns] or [-5.075%; -2.152%]

scenario:EmptyFileBench/benchEmptyFileBaseline

  • 🟥 execution_time [+74.659µs; +315.641µs] or [+2.410%; +10.189%]

scenario:EmptyFileBench/benchEmptyFileBaseline-opcache

  • 🟥 execution_time [+105.846µs; +336.934µs] or [+3.322%; +10.576%]

scenario:EmptyFileBench/benchEmptyFileDdprof

  • 🟥 execution_time [+1.292ms; +1.458ms] or [+51.233%; +57.817%]

scenario:EmptyFileBench/benchEmptyFileDdprof-opcache

  • 🟥 execution_time [+1.334ms; +1.490ms] or [+52.117%; +58.228%]

scenario:EmptyFileBench/benchEmptyFileOverhead

  • 🟥 execution_time [+84.850µs; +366.710µs] or [+2.549%; +11.016%]

scenario:EmptyFileBench/benchEmptyFileOverhead-opcache

  • 🟥 execution_time [+123.278µs; +326.722µs] or [+3.626%; +9.609%]

scenario:LaravelBench/benchLaravelDdprof

  • 🟥 execution_time [+10.079ms; +10.173ms] or [+400.376%; +404.103%]

scenario:SymfonyBench/benchSymfonyDdprof-opcache

  • 🟥 execution_time [+6.368ms; +6.481ms] or [+251.976%; +256.427%]

@Leiyks Leiyks force-pushed the leiyks/fix-laravel-octnae-tests branch 10 times, most recently from 92979ce to bab8bf3 Compare February 12, 2026 12:05
…allbacks

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
…to be ready

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks Leiyks force-pushed the leiyks/fix-laravel-octnae-tests branch 3 times, most recently from 9798f7f to 78ebce2 Compare February 12, 2026 12:41
@Leiyks Leiyks changed the title test(Laravel-Octane): resolve race condition in Laravel Octane test … test: fix multiple CI flakiness issues Feb 12, 2026
@Leiyks Leiyks marked this pull request as ready for review February 12, 2026 12:54
@Leiyks Leiyks requested a review from a team as a code owner February 12, 2026 12:54
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks Leiyks force-pushed the leiyks/fix-laravel-octnae-tests branch from 78ebce2 to 17c6cae Compare February 12, 2026 13:30
@Leiyks Leiyks merged commit f2c976f into master Feb 12, 2026
2060 of 2068 checks passed
@Leiyks Leiyks deleted the leiyks/fix-laravel-octnae-tests branch February 12, 2026 14:13
@github-actions github-actions bot added this to the 1.17.0 milestone Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants