Skip to content

Conversation

@estringana
Copy link
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 11, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 1 New flaky test detected

Zend/tests/fibers/signal-dispatch.phpt (Prevent switching fibers when dispatching pending signals) from php.Zend.tests.fibers (Datadog) (Fix with Cursor)
Fiber start
002- FiberError: Cannot switch fibers in current execution context in %ssignal-dispatch.php:%d
002+ Fiber end
003+ 
004+ 
005+ Fatal error: Uncaught FiberError: Cannot resume a fiber that is not suspended in /usr/local/src/php/Zend/tests/fibers/signal-dispatch.php:27
     Stack trace:
004- #0 %ssignal-dispatch.php(%d): Fiber::suspend()
005- #1 [internal function]: {closure:%s:%d}(%d, Array)
006- #2 %ssignal-dispatch.php(%d): pcntl_signal_dispatch()
...

🧪 1024 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 698dcb900000000045529db792317503
tid: 698dcb9000000000
hexProcessTraceId: 45529db792317503
hexProcessSpanId: 1d23ebc46ce40b34
processTraceId: 4995228348464592131
processSpanId: 2099781080157784884

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
View all
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 99ab139 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.11%. Comparing base (a6f96b3) to head (99ab139).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3641      +/-   ##
==========================================
- Coverage   62.20%   62.11%   -0.09%     
==========================================
  Files         141      141              
  Lines       13387    13387              
  Branches     1753     1753              
==========================================
- Hits         8327     8315      -12     
- Misses       4263     4273      +10     
- Partials      797      799       +2     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f96b3...99ab139. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@estringana estringana force-pushed the estringana/fix-integration-tests branch from 7a0e865 to 04e6500 Compare February 11, 2026 16:02
@estringana estringana force-pushed the estringana/fix-integration-tests branch from 3ff0b28 to e5a6633 Compare February 11, 2026 16:50
@estringana estringana force-pushed the estringana/fix-integration-tests branch from e5a6633 to 600244a Compare February 11, 2026 16:51
@pr-commenter
Copy link

pr-commenter bot commented Feb 11, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-02-12 13:31:47

Comparing candidate commit 99ab139 in PR branch estringana/fix-integration-tests with baseline commit a6f96b3 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 189 metrics, 5 unstable metrics.

? 'Skipping on PHP 8.1 non-ZTS because Symfony sends endpoints'
: (skipLaravel74
? 'Skipping on PHP 7.4 non-ZTS because of Laravel sends endpoints'
: ''))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this makes much sense. Maybe the problem is that this is annotated with @Order(1), but this is not actually a test class, it's a trait. Maybe the including test also has a test annotated with @Order(1), or doesn't have the @TestMethodOrder annotation.

Anyway, I think this test can just be removed. It's not testing any observable behaviour. What we care about is whether endpoints are in fact send, not whatever internal state \DDTrace\are_endpoints_collected() returns

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree. We need to test that after adding an endpoint \DDTrace\are_endpoints_collected() says so

@estringana estringana marked this pull request as ready for review February 12, 2026 12:32
@estringana estringana requested a review from a team as a code owner February 12, 2026 12:32
@estringana estringana force-pushed the estringana/fix-integration-tests branch from 9eedc2b to 99ab139 Compare February 12, 2026 12:34
@estringana estringana merged commit c34b448 into master Feb 12, 2026
1915 of 1920 checks passed
@estringana estringana deleted the estringana/fix-integration-tests branch February 12, 2026 14:26
@github-actions github-actions bot added this to the 1.17.0 milestone Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants