Skip to content

Conversation

@leoromanovsky
Copy link

Motivation

This is PR 1/2 for adding Feature Flagging and Experimentation (FFE) support to dd-trace-php.

Bumps the libdatadog submodule to include DataDog/libdatadog#1532 which adds:

  • RemoteConfigProduct::FfeFlags
  • RemoteConfigCapabilities::FfeFlagConfigurationRules
  • RemoteConfigData::FfeFlags variant

Changes

  • Update libdatadog submodule → ed316b638
  • Regenerate Cargo.lock (pin home, rmp, rmp-serde for CI compatibility)

Plan

PR Description Status
This PR libdatadog bump (FFE RC plumbing) draft
PR 2 FFE evaluation engine + PHP provider + tests stacked on this

Reference implementation: #3630

Update libdatadog submodule to include:
- feat: Add FFE_FLAGS remote config product and capability (#1532)

This adds RemoteConfigProduct::FfeFlags, RemoteConfigCapabilities::
FfeFlagConfigurationRules, and RemoteConfigData::FfeFlags to the
remote config layer. Required for the PHP FFE integration (PR #2).

Cargo.lock regenerated with pins for CI compatibility:
home→0.5.9, rmp→0.8.14, rmp-serde→1.3.0 (edition2024 crates).
@datadog-official
Copy link

datadog-official bot commented Feb 12, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 27 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 698d23f3000000006c95af13c57a725b
tid: 698d23f300000000
hexProcessTraceId: 6c95af13c57a725b
hexProcessSpanId: ec977b2621f3d8ee
processTraceId: 7824352427078480475
processSpanId: 17048230318142904558

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 698d23e900000000000a61996dc5cbd9
tid: 698d23e900000000
hexProcessTraceId: 000a61996dc5cbd9
hexProcessSpanId: 37290548dc4674e0
processTraceId: 2922061366676441
processSpanId: 3974713956622562528
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f3d286f | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@leoromanovsky
Copy link
Author

Superseded — going with single PR #3630 instead of stacked approach.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.20%. Comparing base (b9986f9) to head (f3d286f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3642      +/-   ##
==========================================
- Coverage   62.21%   62.20%   -0.02%     
==========================================
  Files         141      141              
  Lines       13387    13387              
  Branches     1753     1753              
==========================================
- Hits         8329     8327       -2     
- Misses       4260     4263       +3     
+ Partials      798      797       -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9986f9...f3d286f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants