Skip to content

Vlad/315 lib injection ssi - #19258

Merged
vlad-scherbich merged 1 commit into
vlad/315-official-supportfrom
vlad/315-lib-injection-ssi
Jul 24, 2026
Merged

Vlad/315 lib injection ssi#19258
vlad-scherbich merged 1 commit into
vlad/315-official-supportfrom
vlad/315-lib-injection-ssi

Conversation

@vlad-scherbich

@vlad-scherbich vlad-scherbich commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

prev: #19260 | next: #19259

Summary

SSI allow-list + wheel download for 3.15 auto-instrumentation (GAP-01). Closes #17813.

Test plan

  • lib-injection CI green

@datadog-datadog-us1-prod

This comment has been minimized.

@pr-commenter

pr-commenter Bot commented Jul 23, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-23 14:12:13

Comparing candidate commit fc38b6e in PR branch vlad/315-lib-injection-ssi with baseline commit 528a085 in branch main.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 614 metrics, 10 unstable metrics.

scenario:iastaspects-index_aspect

  • 🟥 execution_time [+14.996µs; +17.808µs] or [+10.997%; +13.060%]

scenario:iastaspects-title_aspect

  • 🟥 execution_time [+27.838µs; +34.463µs] or [+8.347%; +10.333%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+64.680µs; +72.345µs] or [+15.628%; +17.480%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+225.836ns; +270.294ns] or [+10.641%; +12.736%]

@vlad-scherbich
vlad-scherbich force-pushed the vlad/315-lib-injection-ssi branch 2 times, most recently from 2d5b2a6 to 6d46dc4 Compare July 23, 2026 14:15
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codeowners resolved as

lib-injection/dl_wheels.py                                              @DataDog/apm-core-python
lib-injection/sources/sitecustomize.py                                  @DataDog/apm-core-python

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jul 23, 2026

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 33 circular imports that already exist on the base branch and have not been changed by this PR.

Show existing cycles (showing 5 of 33 shortest)
ddtrace.internal.datastreams -> ddtrace.internal.datastreams.google_cloud_pubsub -> ddtrace.internal.datastreams
ddtrace.internal.datastreams -> ddtrace.internal.datastreams.kombu -> ddtrace.internal.datastreams
ddtrace.internal.datastreams -> ddtrace.internal.datastreams.kafka -> ddtrace.internal.datastreams
ddtrace.internal.datastreams -> ddtrace.internal.datastreams.botocore -> ddtrace.internal.datastreams
ddtrace.internal.core -> ddtrace._trace.span -> ddtrace.internal.core

To see all cycles, download the cycles-base.json and cycles-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/cycles.py compare cycles-base.json cycles-pr.json

@vlad-scherbich
vlad-scherbich changed the base branch from main to vlad/315-profiling-dev-tooling July 23, 2026 14:18
@vlad-scherbich
vlad-scherbich force-pushed the vlad/315-profiling-dev-tooling branch from 43e0460 to 188e9f2 Compare July 23, 2026 14:32
@vlad-scherbich
vlad-scherbich force-pushed the vlad/315-lib-injection-ssi branch from 6d46dc4 to 7c48279 Compare July 23, 2026 14:32
Bump sitecustomize allow-list to 3.16 (strict less-than) and add 3.15 to
dl_wheels supported_versions. Supersedes #17977 (GAP-01); merge after the
profiling stack lands.
@vlad-scherbich
vlad-scherbich force-pushed the vlad/315-profiling-dev-tooling branch from 188e9f2 to 233cb59 Compare July 24, 2026 01:25
@vlad-scherbich
vlad-scherbich force-pushed the vlad/315-lib-injection-ssi branch from 7c48279 to 140cbc6 Compare July 24, 2026 01:25
Base automatically changed from vlad/315-profiling-dev-tooling to vlad/315-official-support July 24, 2026 01:25
@vlad-scherbich
vlad-scherbich merged commit 140cbc6 into vlad/315-official-support Jul 24, 2026
3 of 6 checks passed
@vlad-scherbich
vlad-scherbich deleted the vlad/315-lib-injection-ssi branch July 24, 2026 01:25
@vlad-scherbich
vlad-scherbich restored the vlad/315-lib-injection-ssi branch July 24, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant