Skip to content

chore(profiling): native test install subdirs (PROF-14200) - #19268

Closed
vlad-scherbich wants to merge 1 commit into
vlad/315-peripheral-compatfrom
vlad/profiling-native-test-install-subdir
Closed

chore(profiling): native test install subdirs (PROF-14200)#19268
vlad-scherbich wants to merge 1 commit into
vlad/315-peripheral-compatfrom
vlad/profiling-native-test-install-subdir

Conversation

@vlad-scherbich

@vlad-scherbich vlad-scherbich commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

prev: #19267 | next: #19269

Summary

INSTALL_SUBDIR for py3.15 native tests. Replaces merged #19257.

Test plan

  • CI green on this branch
  • Stack merges cleanly into the next PR's base branch

Tracker

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Jul 24, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d9bcea5 | Docs | View more details | Give us feedback!

@vlad-scherbich
vlad-scherbich force-pushed the vlad/315-peripheral-compat branch from 32359ee to 9e90c28 Compare August 21, 2026 04:53
@vlad-scherbich
vlad-scherbich force-pushed the vlad/profiling-native-test-install-subdir branch from 25b13ee to 1bbb7e3 Compare August 21, 2026 04:53
@vlad-scherbich
vlad-scherbich force-pushed the vlad/315-peripheral-compat branch from 29c8910 to 107d29b Compare August 21, 2026 08:42
Allows version-specific native test binaries to install into a subdir
of the shared test/ directory (e.g. INSTALL_SUBDIR py315 -> test/py315/).

build_base_venvs runs in parallel across all Python versions and GitLab
merges all artifacts into a single directory for downstream jobs. Without
isolation a binary compiled for pyX.Y (RPATH -> libpythonX.Y) lands in
the shared test/ directory and crashes when the pytest gtest plugin tries
to run it against a different Python runtime.

Callers that do not pass INSTALL_SUBDIR are unaffected.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vlad-scherbich
vlad-scherbich force-pushed the vlad/profiling-native-test-install-subdir branch from 1bbb7e3 to d9bcea5 Compare August 21, 2026 08:43
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against vlad/315-peripheral-compat using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

ddtrace/internal/datadog/profiling/stack/test/CMakeLists.txt            @DataDog/profiling-python

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 250 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 250 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=135)
ddtrace.llmobs._integrations.crewai -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.internal.opentelemetry.span -×-> ddtrace.trace  (product:opentelemetry -> product:tracing, score=133)
ddtrace.llmobs._integrations.langchain -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.llmobs._integrations.langgraph -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@vlad-scherbich

Copy link
Copy Markdown
Contributor Author

Absorbed into consolidated profiling stack — see survivor PR in consolidation comment on the stack.

@vlad-scherbich

Copy link
Copy Markdown
Contributor Author

Closed: INSTALL_SUBDIR / native test install work merged into #19269 (native ABI + install subdirs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant