Skip to content

feat(config): introduce the global DD_AGENTLESS_ENABLED flag - #19631

Open
bwoebi wants to merge 5 commits into
mainfrom
bob/agentless-setting
Open

feat(config): introduce the global DD_AGENTLESS_ENABLED flag#19631
bwoebi wants to merge 5 commits into
mainfrom
bob/agentless-setting

Conversation

@bwoebi

@bwoebi bwoebi commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Centralizing any agentless configs in a single place, making DD_AGENTLESS_ENABLED the fallback for any more specific agentless settings.

Also integrates agentless RC in particular.

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Tests

⚠️ Warnings

❄️ 5 New flaky tests detected

test_build_real_with_mocks_restores_the_agentless_config[py3.10] from test_session_manager.py   View in Datadog
assert (False, False, 'test-key') == (False, False, None)
  
  At index 2 diff: 'test-key' != None
  
  Full diff:
    (
        False,
        False,
  -     None,
  +     'test-key',
...
test_build_real_with_mocks_restores_the_agentless_config[py3.11] from test_session_manager.py   View in Datadog
assert (False, False, 'test-key') == (False, True, 'test-api-key')
  
  At index 1 diff: False != True
  
  Full diff:
    (
        False,
  -     True,
  +     False,
  -     'test-api-key',
...

View in Flaky Test Management

ℹ️ Info

No other issues found (see more)

🧪 All tests passed

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6cd77ff | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Aug 11, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-08-22 06:14:19

Comparing candidate commit 6cd77ff in PR branch bob/agentless-setting with baseline commit 3bb9ecd in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 6 performance regressions! Performance is the same for 616 metrics, 10 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationextract-wsgi_valid_headers_all

  • 🟥 execution_time [+592.649ns; +638.137ns] or [+11.025%; +11.871%]

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+1.477µs; +1.588µs] or [+7.832%; +8.421%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+105.125µs; +111.528µs] or [+27.051%; +28.698%]

scenario:span-start

  • 🟥 execution_time [+1.866ms; +2.037ms] or [+12.822%; +14.001%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+392.316ns; +443.027ns] or [+14.387%; +16.247%]

scenario:tracer-small

  • 🟥 execution_time [+32.850µs; +35.435µs] or [+9.772%; +10.541%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

  • unstable execution_time [-808.199ns; +679.662ns] or [-7.260%; +6.105%]

scenario:coreapiscenario-core_dispatch_1_listener

  • unstable execution_time [-32.909ns; +32.872ns] or [-5.403%; +5.397%]

scenario:coreapiscenario-core_dispatch_50_listeners

  • unstable execution_time [-1580.475ns; +1744.548ns] or [-9.259%; +10.220%]

scenario:coreapiscenario-core_dispatch_exception_listeners

  • unstable execution_time [-1165.045ns; +1298.096ns] or [-9.003%; +10.031%]

scenario:coreapiscenario-core_dispatch_listeners

  • unstable execution_time [-305.286ns; +349.413ns] or [-8.305%; +9.506%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

  • unstable execution_time [-217.630ns; +294.868ns] or [-7.476%; +10.129%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

  • unstable execution_time [-75.020ns; +75.062ns] or [-6.586%; +6.590%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

  • unstable execution_time [-3334.989ns; +4646.969ns] or [-8.223%; +11.457%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • unstable execution_time [-589.369ns; +952.931ns] or [-7.342%; +11.871%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

  • unstable execution_time [-57.457µs; +63.523µs] or [-8.988%; +9.937%]

@bwoebi bwoebi changed the title Introduce the global DD_AGENTLESS_ENABLED flag feat(agentless): Introduce the global DD_AGENTLESS_ENABLED flag Aug 11, 2026
@bwoebi bwoebi changed the title feat(agentless): Introduce the global DD_AGENTLESS_ENABLED flag feat(config): Introduce the global DD_AGENTLESS_ENABLED flag Aug 11, 2026
Comment thread ddtrace/internal/settings/dynamic_instrumentation.py Outdated
@bwoebi
bwoebi force-pushed the bob/agentless-setting branch from acc71f6 to 519b315 Compare August 12, 2026 11:10
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

.github/workflows/build_python_3.yml                                    @DataDog/python-guild @DataDog/apm-core-python
.gitlab/scripts/windows-docker-build.ps1                                @DataDog/python-guild @DataDog/apm-core-python
ddtrace/debugging/_uploader.py                                          @DataDog/debugger-python
ddtrace/internal/core/crashtracking.py                                  @DataDog/profiling-python @DataDog/apm-core-python
ddtrace/internal/native/_native.pyi                                     @DataDog/apm-core-python
ddtrace/internal/opentelemetry/logs.py                                  @DataDog/apm-sdk-capabilities-python
ddtrace/internal/opentelemetry/metrics.py                               @DataDog/apm-sdk-capabilities-python
ddtrace/internal/remoteconfig/client.py                                 @DataDog/remote-config @DataDog/apm-core-python
ddtrace/internal/remoteconfig/worker.py                                 @DataDog/remote-config @DataDog/apm-core-python
ddtrace/internal/settings/_agentless.py                                 @DataDog/apm-core-python
ddtrace/internal/settings/_config.py                                    @DataDog/python-guild @DataDog/apm-sdk-capabilities-python
ddtrace/internal/settings/_opentelemetry.py                             @DataDog/apm-sdk-capabilities-python
ddtrace/internal/settings/_supported_configurations.py                  @DataDog/apm-python
ddtrace/internal/settings/_telemetry.py                                 @DataDog/apm-core-python
ddtrace/internal/settings/dynamic_instrumentation.py                    @DataDog/debugger-python
ddtrace/internal/symbol_db/symbols.py                                   @DataDog/debugger-python
ddtrace/internal/telemetry/writer.py                                    @DataDog/apm-python
ddtrace/internal/writer/writer.py                                       @DataDog/apm-core-python
ddtrace/testing/internal/http.py                                        @DataDog/ci-app-libraries
ddtrace/testing/internal/pytest/plugin.py                               @DataDog/ci-app-libraries
docs/configuration.rst                                                  @DataDog/python-guild
releasenotes/notes/agentless-enabled-global-setting-3f1a9c2e7b4d8065.yaml  @DataDog/apm-python
scripts/supported_configurations.py                                     @DataDog/apm-sdk-capabilities-python
src/native/Cargo.lock                                                   @DataDog/apm-core-python
src/native/Cargo.toml                                                   @DataDog/apm-core-python
src/native/crashtracker.rs                                              @DataDog/profiling-python @DataDog/apm-core-python
src/native/data_pipeline/mod.rs                                         @DataDog/apm-core-python
src/native/rc_shm.rs                                                    @DataDog/apm-core-python
src/native/remote_config.rs                                             @DataDog/apm-core-python
supported-configurations.json                                           @DataDog/apm-python
tests/crashtracker/test_crashtracker.py                                 @DataDog/profiling-python
tests/internal/remoteconfig/test_remoteconfig_native.py                 @DataDog/remote-config @DataDog/apm-core-python
tests/opentelemetry/test_config.py                                      @DataDog/apm-sdk-capabilities-python
tests/telemetry/test_writer.py                                          @DataDog/apm-python
tests/testing/internal/pytest/test_pytest_log_correlation.py            @DataDog/ci-app-libraries
tests/testing/internal/test_bazel_offline_session_manager.py            @DataDog/ci-app-libraries
tests/testing/internal/test_http.py                                     @DataDog/ci-app-libraries
tests/testing/internal/test_session_manager.py                          @DataDog/ci-app-libraries
tests/testing/mocks.py                                                  @DataDog/ci-app-libraries
tests/tracer/test_global_config.py                                      @DataDog/apm-sdk-capabilities-python
tests/tracer/test_writer.py                                             @DataDog/apm-sdk-capabilities-python
tests/utils.py                                                          @DataDog/python-guild

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 12, 2026

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 250 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 250 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=135)
ddtrace.llmobs._integrations.openai -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.llmobs._integrations.claude_agent_sdk -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.debugging._debugger -×-> ddtrace.trace  (product:debugging -> product:tracing, score=133)
ddtrace.internal.test_visibility.api -×-> ddtrace.trace  (product:ci_visibility -> product:tracing, score=133)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 12, 2026

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

@bwoebi bwoebi changed the title feat(config): Introduce the global DD_AGENTLESS_ENABLED flag feat(config): introduce the global DD_AGENTLESS_ENABLED flag Aug 12, 2026
Base automatically changed from bob/libdd-debugger to main August 12, 2026 13:14
@bwoebi
bwoebi force-pushed the bob/agentless-setting branch 2 times, most recently from 0b92f6e to 5d13957 Compare August 12, 2026 14:18
@bwoebi

bwoebi commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d139570b7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ddtrace/internal/settings/_agentless.py
@bwoebi
bwoebi force-pushed the bob/agentless-setting branch from 568f1a7 to 0d85fbe Compare August 21, 2026 23:24
@bwoebi
bwoebi force-pushed the bob/agentless-setting branch from 0d85fbe to 4918699 Compare August 22, 2026 01:07
@bwoebi
bwoebi marked this pull request as ready for review August 22, 2026 01:51
@bwoebi
bwoebi requested review from a team as code owners August 22, 2026 01:51
@bwoebi
bwoebi requested review from a team as code owners August 22, 2026 01:51

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4918699c73

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ddtrace/internal/settings/_opentelemetry.py Outdated
Comment thread ddtrace/internal/core/crashtracking.py
Comment thread ddtrace/debugging/_uploader.py
Comment thread ddtrace/internal/settings/_config.py
Comment thread ddtrace/internal/telemetry/writer.py
Comment thread tests/testing/mocks.py Outdated

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: FAIL

The global flag can send traces to the Datadog intake when the user sets a different OTLP trace endpoint. It can also select the wrong OTLP protocol, remove intake authentication with custom headers, and use the wrong trace-stats default.

Open Bits AI session

🤖 Datadog Autotest · Commit 4918699 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

Comment thread ddtrace/internal/settings/_config.py
Comment thread ddtrace/internal/settings/_opentelemetry.py
Comment thread ddtrace/internal/opentelemetry/metrics.py Outdated
Comment thread ddtrace/internal/settings/_config.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants