Skip to content

fix(dbm): Make pg_plan comes first before dbm_comment - #19783

Draft
Boksam wants to merge 1 commit into
mainfrom
junwoo.park/pg-hint-ignored-by-dbm-comment
Draft

fix(dbm): Make pg_plan comes first before dbm_comment#19783
Boksam wants to merge 1 commit into
mainfrom
junwoo.park/pg-hint-ignored-by-dbm-comment

Conversation

@Boksam

@Boksam Boksam commented Aug 20, 2026

Copy link
Copy Markdown
Member

Description

Closes #19775

Testing

  • Should verify if dbm_comment can be placed anywhere other than the very beginning.

Risks

Additional Notes

@Boksam Boksam self-assigned this Aug 20, 2026
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

ddtrace/propagation/_database_monitoring.py                             @DataDog/apm-sdk-capabilities-python
tests/internal/test_database_monitoring.py                              @DataDog/apm-core-python

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Pipelines  Tests

Unblock PR with BitsAI

⚠️ Warnings

🚦 11 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v126532274-233089d-musllinux_1_2_x86_64, 1] — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitLab

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741357-d2b8243-manylinux2014_aarch64, 1] — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitLab

DataDog/apm-reliability/dd-trace-py | build linux: [amd64, cp315-cp315, v126532274-233089d-musllinux_1_2_x86_64] — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitLab

View all 11 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0724334 | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Aug 20, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-08-20 08:49:20

Comparing candidate commit 0724334 in PR branch junwoo.park/pg-hint-ignored-by-dbm-comment with baseline commit d9fdb65 in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 11 performance regressions! Performance is the same for 611 metrics, 10 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationextract-wsgi_valid_headers_all

  • 🟥 execution_time [+389.537ns; +455.865ns] or [+7.069%; +8.272%]

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+1.681µs; +1.853µs] or [+8.776%; +9.679%]

scenario:iastaspects-casefold_noaspect

  • 🟥 execution_time [+38.817µs; +45.563µs] or [+15.521%; +18.219%]

scenario:iastaspects-strip_aspect

  • 🟥 execution_time [+29.771µs; +39.259µs] or [+10.210%; +13.464%]

scenario:iastaspects-translate_noaspect

  • 🟥 execution_time [+25.502µs; +35.108µs] or [+7.216%; +9.934%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+112.483µs; +120.519µs] or [+27.317%; +29.268%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+25.214µs; +28.036µs] or [+18.184%; +20.219%]

scenario:samplingrules-high_match

  • 🟥 execution_time [+11.491µs; +12.818µs] or [+7.311%; +8.156%]

scenario:span-start

  • 🟥 execution_time [+1.340ms; +1.507ms] or [+8.951%; +10.067%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+449.049ns; +487.102ns] or [+16.295%; +17.676%]

scenario:tracer-small

  • 🟥 execution_time [+24.373µs; +26.622µs] or [+7.199%; +7.863%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

  • unstable execution_time [-1028.105ns; +443.977ns] or [-9.119%; +3.938%]

scenario:coreapiscenario-core_dispatch_1_listener

  • unstable execution_time [-39.497ns; +27.787ns] or [-6.421%; +4.517%]

scenario:coreapiscenario-core_dispatch_50_listeners

  • unstable execution_time [-1694.052ns; +1597.677ns] or [-9.979%; +9.411%]

scenario:coreapiscenario-core_dispatch_exception_listeners

  • unstable execution_time [-1641.142ns; +877.634ns] or [-12.206%; +6.527%]

scenario:coreapiscenario-core_dispatch_listeners

  • unstable execution_time [-368.368ns; +279.284ns] or [-9.935%; +7.532%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

  • unstable execution_time [-232.736ns; +287.359ns] or [-7.931%; +9.793%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

  • unstable execution_time [-113.250ns; +31.028ns] or [-9.599%; +2.630%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

  • unstable execution_time [-4648.057ns; +3467.212ns] or [-11.225%; +8.373%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • unstable execution_time [-762.571ns; +765.482ns] or [-9.407%; +9.443%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

  • unstable execution_time [-56.600µs; +64.274µs] or [-8.868%; +10.070%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DBM SQL comments hide leading pg_hint_plan hints

1 participant