Skip to content

ci: new system-tests gitlab pipeline - #19787

Draft
nccatoni wants to merge 3 commits into
mainfrom
revert-19784-revert-18578-nccatoni/test-system-tests-gitlab
Draft

ci: new system-tests gitlab pipeline#19787
nccatoni wants to merge 3 commits into
mainfrom
revert-19784-revert-18578-nccatoni/test-system-tests-gitlab

Conversation

@nccatoni

@nccatoni nccatoni commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Description

Testing

Risks

Additional Notes

@nccatoni nccatoni changed the title Revert "ci: revert new system-tests gitlab pipeline (#19784)" ci: new system-tests gitlab pipeline Aug 20, 2026
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

.gitlab/system-tests.yml                                                @DataDog/python-guild @DataDog/apm-core-python
scripts/update-system-tests-version.py                                  @DataDog/python-guild

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 20, 2026

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Pipelines  Tests

Unblock PR with BitsAI

⚠️ Warnings

🚦 9 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64, 1] — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitLab

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v126532274-233089d-musllinux_1_2_x86_64, 1] — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitLab

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741357-d2b8243-manylinux2014_aarch64, 1] — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitLab

View all 9 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog auto-retried 1 job - 0 passed on retry View in Datadog

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: dc4b0ee | Docs | View more details | Give us feedback!

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 20, 2026

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 252 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 252 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=135)
ddtrace.llmobs._integrations.mcp -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.llmobs._telemetry -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.llmobs._integrations.vertexai -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.profiling.collector.pytorch -×-> ddtrace.trace  (product:profiling -> product:tracing, score=133)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@pr-commenter

pr-commenter Bot commented Aug 20, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-08-21 12:13:52

Comparing candidate commit dc4b0ee in PR branch revert-19784-revert-18578-nccatoni/test-system-tests-gitlab with baseline commit db3cb3e in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 10 performance regressions! Performance is the same for 609 metrics, 10 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationextract-b3_single_headers

  • 🟥 execution_time [+1.240µs; +1.343µs] or [+13.194%; +14.283%]

scenario:httppropagationextract-wsgi_valid_headers_all

  • 🟥 execution_time [+492.404ns; +540.331ns] or [+9.058%; +9.940%]

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+1.479µs; +1.647µs] or [+7.715%; +8.595%]

scenario:iastaspects-casefold_noaspect

  • 🟥 execution_time [+47.588µs; +58.432µs] or [+19.386%; +23.804%]

scenario:iastaspects-swapcase_aspect

  • 🟥 execution_time [+43.383µs; +53.149µs] or [+15.661%; +19.187%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+102.643µs; +113.381µs] or [+24.422%; +26.976%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+16.580µs; +20.311µs] or [+11.465%; +14.045%]

scenario:span-start

  • 🟥 execution_time [+1.235ms; +1.424ms] or [+8.238%; +9.500%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+502.907ns; +546.191ns] or [+18.647%; +20.252%]

scenario:tracer-small

  • 🟥 execution_time [+30.056µs; +32.113µs] or [+9.293%; +9.929%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

  • unstable execution_time [-785.394ns; +692.145ns] or [-7.129%; +6.283%]

scenario:coreapiscenario-core_dispatch_1_listener

  • unstable execution_time [-34.423ns; +31.751ns] or [-5.628%; +5.191%]

scenario:coreapiscenario-core_dispatch_50_listeners

  • unstable execution_time [-1681.561ns; +1618.392ns] or [-9.896%; +9.524%]

scenario:coreapiscenario-core_dispatch_exception_listeners

  • unstable execution_time [-1309.051ns; +1179.878ns] or [-9.979%; +8.995%]

scenario:coreapiscenario-core_dispatch_listeners

  • unstable execution_time [-321.085ns; +328.593ns] or [-8.739%; +8.944%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

  • unstable execution_time [-246.830ns; +265.685ns] or [-8.445%; +9.090%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

  • unstable execution_time [-68.899ns; +76.550ns] or [-6.067%; +6.741%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

  • unstable execution_time [-3970.067ns; +4023.866ns] or [-9.737%; +9.869%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • unstable execution_time [-755.613ns; +802.878ns] or [-9.316%; +9.898%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

  • unstable execution_time [-61124.117ns; +60293.024ns] or [-9.520%; +9.391%]

@nccatoni nccatoni added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 20, 2026
@nccatoni
nccatoni force-pushed the revert-19784-revert-18578-nccatoni/test-system-tests-gitlab branch from f4e0ef5 to dc4b0ee Compare August 21, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant